| Summary: | Fix OwnPtr strict errors in RenderStyle and make StyleRareInheritedData::textShadow an OwnPtr | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | James Robinson <jamesr> | ||||||||
| Component: | New Bugs | Assignee: | James Robinson <jamesr> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | abarth, buildbot, cmarrin, commit-queue, dglazkov, eric, gustavo.noronha, gustavo, ossy, simon.fraser, webkit-ews, webkit.review.bot, xan.lopez | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Other | ||||||||||
| OS: | OS X 10.5 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
James Robinson
2011-04-25 16:09:32 PDT
Created attachment 90983 [details]
Patch
Gonna let this one run through the EWS before landing. Attachment 90983 [details] did not build on qt: Build output: http://queues.webkit.org/results/8508392 Attachment 90983 [details] did not build on win: Build output: http://queues.webkit.org/results/8506515 Attachment 90983 [details] did not build on chromium: Build output: http://queues.webkit.org/results/8504862 Attachment 90983 [details] did not build on mac: Build output: http://queues.webkit.org/results/8506538 Attachment 90983 [details] did not build on chromium: Build output: http://queues.webkit.org/results/8505698 Attachment 90983 [details] did not build on gtk: Build output: http://queues.webkit.org/results/8503868 AnimationBase has a function ptr to the setter which now takes a PassOwnPtr<>. I've fixed it locally, will check if it compiles now and upload a new patch. Thanks, EWS! > Thanks, EWS!
You're welcome.
Created attachment 91054 [details]
Patch
Comment on attachment 91054 [details]
Patch
LGTM.
Committed r84877: <http://trac.webkit.org/changeset/84877> Attachment 90983 [details] did not build on chromium: Build output: http://queues.webkit.org/results/8505740 http://trac.webkit.org/changeset/84877 might have broken SnowLeopard Intel Release (Tests) It make a test fail at least of on SL, GTK, Qt bots: --- /Volumes/Data/WebKit-BuildSlave/snowleopard-intel-release-tests/build/layout-test-results/transitions/multiple-text-shadow-transition-expected.txt 2011-04-25 23:44:44.000000000 -0700 +++ /Volumes/Data/WebKit-BuildSlave/snowleopard-intel-release-tests/build/layout-test-results/transitions/multiple-text-shadow-transition-actual.txt 2011-04-25 23:44:44.000000000 -0700 @@ -1,2 +1,2 @@ Shadowed text -PASS: saw 5 shadows during the transition +FAIL: saw 1 shadows during the transition (In reply to comment #15) > http://trac.webkit.org/changeset/84877 might have broken SnowLeopard Intel Release (Tests) Rolled out by http://trac.webkit.org/changeset/84901 Created attachment 91178 [details]
Patch
The test failed because I had mishandled ShadowData's linked list implementation. This patch handles the linked list correctly (using smart pointers instead of raw ptrs + delete calls) and I've actually compiled+ran the tests with it (how novel!). Comment on attachment 91178 [details]
Patch
OK!
The commit-queue encountered the following flaky tests while processing attachment 91178 [details]: http/tests/xmlhttprequest/basic-auth.html bug 51613 (author: ap@webkit.org) The commit-queue is continuing to process your patch. Comment on attachment 91178 [details] Patch Clearing flags on attachment: 91178 Committed r85027: <http://trac.webkit.org/changeset/85027> All reviewed patches have been landed. Closing bug. |