Summary: | [Qt]Fix tst_QWebFrame::setUrlToInvalid() autotest after r84762 | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Csaba Osztrogonác <ossy> | ||||||
Component: | Tools / Tests | Assignee: | Caio Marcelo de Oliveira Filho <cmarcelo> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | ademar, cmarcelo, commit-queue, kenneth, ossy, rafael.lobo | ||||||
Priority: | P2 | Keywords: | Qt, QtTriaged | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 38654 | ||||||||
Attachments: |
|
Description
Csaba Osztrogonác
2011-04-25 14:28:07 PDT
updated error message with r86748: FAIL! : tst_QWebFrame::setUrlToInvalid() Compared values are not the same Actual (frame->url()): http://here/ Expected (invalidUrl): http:/here Loc: [/ramdisk/qt-linux-release/build/Source/WebKit/qt/tests/qwebframe/tst_qwebframe.cpp(3462)] Created attachment 94069 [details]
mark failing test cases as expected fail
This is a month old regression, so it is time to mark the
failing test cases as expected fail to make buildbot happier.
We can easily catch regressions if all tests passes on the bot.
The commit-queue encountered the following flaky tests while processing attachment 94069 [details]: inspector/debugger/source-frame.html bug 57399 (author: podivilov@chromium.org) The commit-queue is continuing to process your patch. Comment on attachment 94069 [details] mark failing test cases as expected fail Clearing flags on attachment: 94069 Committed r86946: <http://trac.webkit.org/changeset/86946> All reviewed patches have been landed. Closing bug. Reopen to fix the bug. The commit-queue encountered the following flaky tests while processing attachment 94069 [details]: animations/suspend-resume-animation.html bug 48161 (authors: cmarrin@apple.com and simon.fraser@apple.com) The commit-queue is continuing to process your patch. Created attachment 95300 [details]
Patch
Comment on attachment 95300 [details]
Patch
ok
Comment on attachment 95300 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=95300&action=review > Source/WebKit/qt/tests/qwebframe/tst_qwebframe.cpp:3462 > + const QUrl validUrl("http://example.com/"); Shouldnt this be with one / then? or (In reply to comment #10) > (From update of attachment 95300 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=95300&action=review > > > Source/WebKit/qt/tests/qwebframe/tst_qwebframe.cpp:3462 > > + const QUrl validUrl("http://example.com/"); > > Shouldnt this be with one / then? or No, this one is the valid URL that QWebFrame will end up with when you feed with the invalid one. So all url() and family will have the valid one now. (In reply to comment #11) > (In reply to comment #10) > > (From update of attachment 95300 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=95300&action=review > > > > > Source/WebKit/qt/tests/qwebframe/tst_qwebframe.cpp:3462 > > > + const QUrl validUrl("http://example.com/"); > > > > Shouldnt this be with one / then? or > > No, this one is the valid URL that QWebFrame will end up with when you feed with the invalid one. So all url() and family will have the valid one now. ok fine :-) pls commit Comment on attachment 95300 [details] Patch Clearing flags on attachment: 95300 Committed r87818: <http://trac.webkit.org/changeset/87818> All reviewed patches have been landed. Closing bug. The commit-queue encountered the following flaky tests while processing attachment 95300 [details]: http/tests/websocket/tests/frame-length-longer-than-buffer.html bug 61837 (author: abarth@webkit.org) The commit-queue is continuing to process your patch. Revision r86946 cherry-picked into qtwebkit-2.2 with commit 8234285 <http://gitorious.org/webkit/qtwebkit/commit/8234285> Revision r87818 cherry-picked into qtwebkit-2.2 with commit 0c7056f <http://gitorious.org/webkit/qtwebkit/commit/0c7056f> |