Bug 59323

Summary: Web Inspector: worker messages should be routed to corresponding worker front-end
Product: WebKit Reporter: Yury Semikhatsky <yurys>
Component: Web Inspector (Deprecated)Assignee: Yury Semikhatsky <yurys>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, webkit-ews, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 58541    
Attachments:
Description Flags
Patch
pfeldman: review+
Patch for landing none

Yury Semikhatsky
Reported 2011-04-25 08:40:58 PDT
Since we're going to have one front-end per inspected worker context, there should be a transport that would route worker messages to corresponding front-end.
Attachments
Patch (7.89 KB, patch)
2011-04-25 08:48 PDT, Yury Semikhatsky 		pfeldman: review+
DetailsFormatted DiffDiff
Patch for landing (7.98 KB, patch)
2011-04-25 09:27 PDT, Yury Semikhatsky 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yury Semikhatsky
Comment 1 2011-04-25 08:48:54 PDT
Created attachment 90919 [details] Patch
Early Warning System Bot
Comment 2 2011-04-25 08:58:10 PDT
Attachment 90919 [details] did not build on qt: Build output: http://queues.webkit.org/results/8504707
Pavel Feldman
Comment 3 2011-04-25 09:07:38 PDT
Comment on attachment 90919 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=90919&action=review > Source/WebCore/inspector/front-end/WorkerManager.js:82 > + workerId = parseInt(workerId, 10); parseInt(workerId) > Source/WebCore/inspector/front-end/WorkerManager.js:96 > + this.workerIdToWindow_[workerId] = window.open(url); this._workerIdToWindow
Yury Semikhatsky
Comment 4 2011-04-25 09:27:30 PDT
Created attachment 90920 [details] Patch for landing
Yury Semikhatsky
Comment 5 2011-04-25 09:48:17 PDT
Committed r84780: <http://trac.webkit.org/changeset/84780>
Note You need to log in before you can comment on or make changes to this bug.