Summary: | Remove JSDOMWrapperWithGlobalPointer now that all JSDOMWrappers have global objects | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Sam Weinig <sam> | ||||||
Component: | New Bugs | Assignee: | Sam Weinig <sam> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | abarth, buildbot, eric, webkit-ews, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Other | ||||||||
OS: | OS X 10.5 | ||||||||
Attachments: |
|
Description
Sam Weinig
2011-04-24 21:24:43 PDT
Created attachment 90898 [details]
Patch
Comment on attachment 90898 [details]
Patch
r=ke
Attachment 90898 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/bindings/js/JSDOMWrapper.h:56: Should only a single space after a punctuation in a comment. [whitespace/comments] [5]
Total errors found: 1 in 4 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Attachment 90898 [details] did not build on qt: Build output: http://queues.webkit.org/results/8510141 Attachment 90898 [details] did not build on win: Build output: http://queues.webkit.org/results/8509151 Attachment 90898 [details] did not build on mac: Build output: http://queues.webkit.org/results/8504607 Attachment 90898 [details] did not build on mac: Build output: http://queues.webkit.org/results/8509179 Didn't take. Created attachment 91159 [details]
Updated patch
Attachment 91159 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/bindings/js/JSDOMWrapper.h:56: Should only a single space after a punctuation in a comment. [whitespace/comments] [5]
Total errors found: 1 in 4 files
If any of these errors are false positives, please file a bug against check-webkit-style.
http://trac.webkit.org/changeset/84945 might have broken WinCairo Debug (Build) Comment on attachment 91159 [details]
Updated patch
OMG YOU ARE MY HERO.
Relanded in r84992. |