Bug 59310

Summary:

Remove JSDOMWrapperWithGlobalPointer now that all JSDOMWrappers have global objects

Product:

WebKit

Reporter:

Sam Weinig <sam>

Component:

New Bugs

Assignee:

Sam Weinig <sam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, buildbot, eric, webkit-ews, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	mjs: review+
Updated patch	eric: review+, eric: commit-queue+

Sam Weinig

Reported 2011-04-24 21:24:43 PDT

Remove JSDOMWrapperWithGlobalPointer now that all JSDOMWrappers have global objects

Attachments
Patch (5.92 KB, patch) 2011-04-24 21:27 PDT, Sam Weinig	mjs: review+	Details Formatted Diff Diff
Updated patch (5.91 KB, patch) 2011-04-26 14:21 PDT, Sam Weinig	eric: review+ eric: commit-queue+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Sam Weinig

Comment 1 2011-04-24 21:27:14 PDT

Created attachment 90898 [details] Patch

Maciej Stachowiak

Comment 2 2011-04-24 21:29:27 PDT

Comment on attachment 90898 [details] Patch r=ke

WebKit Review Bot

Comment 3 2011-04-24 21:30:15 PDT

Attachment 90898 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/bindings/js/JSDOMWrapper.h:56: Should only a single space after a punctuation in a comment. [whitespace/comments] [5] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.

Early Warning System Bot

Comment 4 2011-04-24 21:42:30 PDT

Attachment 90898 [details] did not build on qt: Build output: http://queues.webkit.org/results/8510141

Build Bot

Comment 5 2011-04-24 22:19:42 PDT

Attachment 90898 [details] did not build on win: Build output: http://queues.webkit.org/results/8509151

WebKit Review Bot

Comment 6 2011-04-24 23:37:11 PDT

Attachment 90898 [details] did not build on mac: Build output: http://queues.webkit.org/results/8504607

WebKit Review Bot

Comment 7 2011-04-25 01:29:19 PDT

Attachment 90898 [details] did not build on mac: Build output: http://queues.webkit.org/results/8509179

Sam Weinig

Comment 8 2011-04-26 13:23:11 PDT

Landed in r84945.

Sam Weinig

Comment 9 2011-04-26 14:19:18 PDT

Didn't take.

Sam Weinig

Comment 10 2011-04-26 14:21:00 PDT

Created attachment 91159 [details] Updated patch

WebKit Review Bot

Comment 11 2011-04-26 14:25:20 PDT

Attachment 91159 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/bindings/js/JSDOMWrapper.h:56: Should only a single space after a punctuation in a comment. [whitespace/comments] [5] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.

WebKit Review Bot

Comment 12 2011-04-26 14:31:30 PDT

http://trac.webkit.org/changeset/84945 might have broken WinCairo Debug (Build)

Eric Seidel (no email)

Comment 13 2011-04-26 16:21:55 PDT

Comment on attachment 91159 [details] Updated patch OMG YOU ARE MY HERO.

Sam Weinig

Comment 14 2011-04-26 17:56:46 PDT

Relanded in r84992.

Note You need to log in before you can comment on or make changes to this bug.