Bug 5931

Summary:

Remove additional bit-rotted DEBUG* ifdefs from WebCore

Product:

WebKit

Reporter:

Eric Seidel (no email) <eric>

Component:

WebKit Misc.

Assignee:

Eric Seidel (no email) <eric>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

Priority:

Version:

420+

Hardware:

Mac

OS:

OS X 10.4

Bug Depends on:

5877

Bug Blocks:

Attachments:

Description	Flags
CSS_DEBUG removal patch	none
CACHE_DEBUG removal patch	none
PARSER_DEBUG removal patch	darin: review+
TOKEN_DEBUG removal patch	none
DEBUG_LAYOUT removal patch	none
FORMS_DEBUG removal patch	darin: review+
KJS_VERBOSE removal patch	eric: review-
CSS_STYLESHEET_DEBUG removal patch	darin: review+
SPEED_DEBUG removal patch	darin: review-

Eric Seidel (no email)

Reported 2005-12-04 05:43:52 PST

Remove additional bit-rotted DEBUG* ifdefs from WebCore I'd like to propose removing at least some of the following additional bit-rotted #ifdefs from WebCore: CACHE_DEBUG PARSER_DEBUG TOKEN_DEBUG DEBUG_LAYOUT FORMS_DEBUG KJS_VERBOSE CSS_DEBUG CSS_STYLESHEET_DEBUG I'll attach each removal as a separate patch, each one generated using my hacked partial preprocessor from http://bugzilla.opendarwin.org/show_bug.cgi?id=5877

Attachments
CSS_DEBUG removal patch (4.93 KB, patch) 2005-12-04 06:08 PST, Eric Seidel (no email)	no flags	Details Formatted Diff Diff
CACHE_DEBUG removal patch (9.15 KB, patch) 2005-12-04 06:31 PST, Eric Seidel (no email)	no flags	Details Formatted Diff Diff
PARSER_DEBUG removal patch (954 bytes, patch) 2005-12-04 06:35 PST, Eric Seidel (no email)	darin: review+	Details Formatted Diff Diff
TOKEN_DEBUG removal patch (8.62 KB, patch) 2005-12-04 13:31 PST, Eric Seidel (no email)	no flags	Details Formatted Diff Diff
DEBUG_LAYOUT removal patch (30.21 KB, patch) 2005-12-04 13:32 PST, Eric Seidel (no email)	no flags	Details Formatted Diff Diff
FORMS_DEBUG removal patch (1.57 KB, patch) 2005-12-04 13:32 PST, Eric Seidel (no email)	darin: review+	Details Formatted Diff Diff
KJS_VERBOSE removal patch (8.10 KB, patch) 2005-12-04 13:33 PST, Eric Seidel (no email)	eric: review-	Details Formatted Diff Diff
CSS_STYLESHEET_DEBUG removal patch (1.22 KB, patch) 2005-12-04 13:33 PST, Eric Seidel (no email)	darin: review+	Details Formatted Diff Diff
SPEED_DEBUG removal patch (2.70 KB, patch) 2005-12-04 21:45 PST, Eric Seidel (no email)	darin: review-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Eric Seidel (no email)

Comment 1 2005-12-04 06:08:12 PST

Created attachment 4934 [details] CSS_DEBUG removal patch

Eric Seidel (no email)

Comment 2 2005-12-04 06:09:14 PST

Comment on attachment 4934 [details] CSS_DEBUG removal patch Super simple, script-generated patch.

Eric Seidel (no email)

Comment 3 2005-12-04 06:31:30 PST

Created attachment 4935 [details] CACHE_DEBUG removal patch

Eric Seidel (no email)

Comment 4 2005-12-04 06:35:14 PST

Created attachment 4936 [details] PARSER_DEBUG removal patch

Eric Seidel (no email)

Comment 5 2005-12-04 13:31:54 PST

Created attachment 4941 [details] TOKEN_DEBUG removal patch

Eric Seidel (no email)

Comment 6 2005-12-04 13:32:14 PST

Created attachment 4943 [details] DEBUG_LAYOUT removal patch

Eric Seidel (no email)

Comment 7 2005-12-04 13:32:43 PST

Created attachment 4944 [details] FORMS_DEBUG removal patch

Eric Seidel (no email)

Comment 8 2005-12-04 13:33:01 PST

Created attachment 4945 [details] KJS_VERBOSE removal patch

Eric Seidel (no email)

Comment 9 2005-12-04 13:33:28 PST

Created attachment 4946 [details] CSS_STYLESHEET_DEBUG removal patch

Eric Seidel (no email)

Comment 10 2005-12-04 13:35:15 PST

The idea behind these patches is still under discussion on the webkit-dev mailing list, however I'm marking them for review now so that folks can view them easily and make a more informed decision.

Eric Seidel (no email)

Comment 11 2005-12-04 21:45:19 PST

Created attachment 4950 [details] SPEED_DEBUG removal patch

Darin Adler

Comment 12 2005-12-05 06:41:58 PST

Comment on attachment 4950 [details] SPEED_DEBUG removal patch This doens't look right: +#if 0 < 1 You should fix that.

Eric Seidel (no email)

Comment 13 2005-12-11 00:55:58 PST

Comment on attachment 4936 [details] PARSER_DEBUG removal patch Actually, putting this one back up for review, it's so simple, I think we should just land it.

Eric Seidel (no email)

Comment 14 2005-12-11 00:59:16 PST

Comment on attachment 4945 [details] KJS_VERBOSE removal patch There is no way this would apply cleanly anymore anyway.

Eric Seidel (no email)

Comment 15 2005-12-20 01:09:58 PST

I commited the ones which were approved, and left the rest of them alone for now. We'll track those with other bugs.

Note You need to log in before you can comment on or make changes to this bug.