Bug 59274

Summary: [REGRESSION] Value 'none' breaks multiple background-image display
Product: WebKit Reporter: nhackett1+webkit
Component: CSSAssignee: Nobody <webkit-unassigned>
Severity: Normal CC: dglazkov, mihnea, nhackett1+webkit, shanestephens, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
URL: http://nathanhackett.com/multibg.html
Description Flags
Test case
Patch 2
webkit.review.bot: commit-queue-
Archive of layout-test-results from ec2-cr-linux-02
Patch 3
simon.fraser: review+, simon.fraser: commit-queue-
Patch 4 none

Description nhackett1+webkit 2011-04-22 22:04:00 PDT
The test page has three background-image values set. When one of those values is 'none', and a background colour is specified, all subsequent images aren't displayed.
Comment 1 nhackett1+webkit 2011-04-22 22:36:54 PDT
Created attachment 90843 [details]
Test case
Comment 2 Shane Stephens 2011-05-18 20:38:52 PDT
Works in Safari 5.0.4 and Chrome 11, Does not work on Chrome Canary or WebKit nightly on Mac OS 10.6
Comment 3 Mihnea Ovidenie 2011-05-29 02:11:01 PDT
I am working on a fix for it, likely caused by http://trac.webkit.org/changeset/82969 (fix for 57773).
Comment 4 Mihnea Ovidenie 2011-05-29 09:11:47 PDT
Created attachment 95286 [details]

First version of the patch.
Comment 5 Mihnea Ovidenie 2011-07-15 06:01:06 PDT
Created attachment 100961 [details]
Patch 2
Comment 6 WebKit Review Bot 2011-07-15 06:19:39 PDT
Comment on attachment 100961 [details]
Patch 2

Attachment 100961 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/9099204

New failing tests:
Comment 7 WebKit Review Bot 2011-07-15 06:19:45 PDT
Created attachment 100966 [details]
Archive of layout-test-results from ec2-cr-linux-02

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-02  Port: Chromium  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Comment 8 Mihnea Ovidenie 2011-07-15 08:29:42 PDT
Created attachment 100988 [details]
Patch 3

Skip the test on chromium.
Comment 9 Simon Fraser (smfr) 2011-07-15 14:01:34 PDT
Comment on attachment 100988 [details]
Patch 3

View in context: https://bugs.webkit.org/attachment.cgi?id=100988&action=review

> LayoutTests/fast/backgrounds/background-fast-path-simple-color.html:20
> +    Test for <a href="https://bugs.webkit.org/show_bug.cgi?id=59274">https://bugs.webkit.org/show_bug.cgi?id=59274</a>
> +    The test passes if you see a green rectangle below.

If this text were in an HTML comment, the pixel result could be cross-platform.
Comment 10 Mihnea Ovidenie 2011-07-18 07:49:59 PDT
Created attachment 101157 [details]
Patch 4
Comment 11 WebKit Review Bot 2011-07-18 09:54:15 PDT
Comment on attachment 101157 [details]
Patch 4

Clearing flags on attachment: 101157

Committed r91190: <http://trac.webkit.org/changeset/91190>
Comment 12 WebKit Review Bot 2011-07-18 09:54:32 PDT
All reviewed patches have been landed.  Closing bug.