Bug 59254

Summary: DFG JIT - retain VariableRecords for args/var in all basic blocks,
Product: WebKit Reporter: Gavin Barraclough <barraclough>
Component: JavaScriptCoreAssignee: Gavin Barraclough <barraclough>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
The patch ggaren: review+

Gavin Barraclough
Reported 2011-04-22 16:32:22 PDT
such that this information is available for DCE. Also, since this enlarges the size of BasicBlock, make Graph hold a vector of pointers to basic blocks, not a vector of blocks.
Attachments
The patch (18.23 KB, patch)
2011-04-22 16:33 PDT, Gavin Barraclough 		ggaren: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Gavin Barraclough
Comment 1 2011-04-22 16:33:28 PDT
Created attachment 90800 [details] The patch
WebKit Review Bot
Comment 2 2011-04-22 16:34:07 PDT
Attachment 90800 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/ChangeLog:3: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.
Geoffrey Garen
Comment 3 2011-04-22 16:37:47 PDT
Comment on attachment 90800 [details] The patch r=me
Gavin Barraclough
Comment 4 2011-04-22 16:49:15 PDT
Fixed in r84705
Note You need to log in before you can comment on or make changes to this bug.