Summary: | Use native NullPtr when using GCC 4.6.0 and C++0x | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Xan Lopez <xan.lopez> | ||||||||
Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | lucas.de.marchi, pnormand, webkit-ews, webkit.review.bot, xan.lopez | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | PC | ||||||||||
OS: | OS X 10.5 | ||||||||||
Attachments: |
|
Description
Xan Lopez
2011-04-22 16:13:55 PDT
Created attachment 90794 [details]
nullptr.diff
Created attachment 90796 [details]
nullptr.diff
Fix nit.
Attachment 90794 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1
Source/JavaScriptCore/wtf/NullPtr.h:38: Missing space after , [whitespace/comma] [3]
Total errors found: 1 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Attachment 90796 [details] did not build on qt: Build output: http://queues.webkit.org/results/8495608 Created attachment 90812 [details]
nullptr.diff
Try to fix Qt build.
Comment on attachment 90812 [details] nullptr.diff View in context: https://bugs.webkit.org/attachment.cgi?id=90812&action=review > Source/JavaScriptCore/ChangeLog:13 > + use native nullptr. Two extra spaces here. Ping Xan, can you land this? :) Comment on attachment 90812 [details] nullptr.diff Landed in r85521. The build is still totally broken with C++0x though, so don't get your hopes too high. Closing. |