Bug 59252

Summary: Use native NullPtr when using GCC 4.6.0 and C++0x
Product: WebKit Reporter: Xan Lopez <xan.lopez>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: lucas.de.marchi, pnormand, webkit-ews, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
nullptr.diff
none
nullptr.diff
none
nullptr.diff none

Xan Lopez
Reported 2011-04-22 16:13:55 PDT
GCC 4.6.0 supports nullptr when -std=c++0x is used. Detect that in NullPtr.h and don't re-define stuff. This gets rid of a huge warning per compiled file.
Attachments
nullptr.diff (1.81 KB, patch)
2011-04-22 16:15 PDT, Xan Lopez 		no flags
DetailsFormatted DiffDiff
nullptr.diff (1.81 KB, patch)
2011-04-22 16:16 PDT, Xan Lopez 		no flags
DetailsFormatted DiffDiff
nullptr.diff (2.70 KB, patch)
2011-04-22 17:19 PDT, Xan Lopez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Xan Lopez
Comment 1 2011-04-22 16:15:39 PDT
Created attachment 90794 [details] nullptr.diff
Xan Lopez
Comment 2 2011-04-22 16:16:53 PDT
Created attachment 90796 [details] nullptr.diff Fix nit.
WebKit Review Bot
Comment 3 2011-04-22 16:17:43 PDT
Attachment 90794 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/wtf/NullPtr.h:38: Missing space after , [whitespace/comma] [3] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Early Warning System Bot
Comment 4 2011-04-22 16:55:16 PDT
Attachment 90796 [details] did not build on qt: Build output: http://queues.webkit.org/results/8495608
Xan Lopez
Comment 5 2011-04-22 17:19:58 PDT
Created attachment 90812 [details] nullptr.diff Try to fix Qt build.
Alexey Proskuryakov
Comment 6 2011-04-22 21:50:09 PDT
Comment on attachment 90812 [details] nullptr.diff View in context: https://bugs.webkit.org/attachment.cgi?id=90812&action=review > Source/JavaScriptCore/ChangeLog:13 > + use native nullptr. Two extra spaces here.
Philippe Normand
Comment 7 2011-05-02 07:32:45 PDT
Ping Xan, can you land this? :)
Xan Lopez
Comment 8 2011-05-02 14:16:12 PDT
Comment on attachment 90812 [details] nullptr.diff Landed in r85521. The build is still totally broken with C++0x though, so don't get your hopes too high.
Xan Lopez
Comment 9 2011-05-02 14:16:22 PDT
Closing.
Note You need to log in before you can comment on or make changes to this bug.