Bug 59245

Summary:

Add infrastructure to parse an SVN authorization file

Product:

WebKit

Reporter:

Daniel Bates <dbates>

Component:

Tools / Tests

Assignee:

Daniel Bates <dbates>

Status:

NEW

Severity:

Normal

CC:

webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

All

Bug Depends on:

Bug Blocks:

59242

Attachments:

Description	Flags
Patch and unit test	none
Patch and unit test	none
Patch and unit tests	none
Patch and unit tests	none
Patch and unit test	none
Patch and unit test	none

Daniel Bates

Reported 2011-04-22 15:10:58 PDT

Towards the fix for bug #59242, we need to add infrastructure to parse an SVN authorization file.

Attachments
Patch and unit test (9.49 KB, patch) 2011-04-22 15:24 PDT, Daniel Bates	no flags	Details Formatted Diff Diff
Patch and unit test (9.48 KB, patch) 2011-04-22 15:25 PDT, Daniel Bates	no flags	Details Formatted Diff Diff
Patch and unit tests (9.48 KB, patch) 2011-04-22 15:32 PDT, Daniel Bates	no flags	Details Formatted Diff Diff
Patch and unit tests (9.52 KB, patch) 2011-04-22 16:47 PDT, Daniel Bates	no flags	Details Formatted Diff Diff
Patch and unit test (9.51 KB, patch) 2011-04-22 16:57 PDT, Daniel Bates	no flags	Details Formatted Diff Diff
Patch and unit test (9.52 KB, patch) 2011-04-22 17:01 PDT, Daniel Bates	no flags	Details Formatted Diff Diff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.

Daniel Bates

Comment 1 2011-04-22 15:24:31 PDT

Created attachment 90778 [details] Patch and unit test

Daniel Bates

Comment 2 2011-04-22 15:25:54 PDT

Created attachment 90779 [details] Patch and unit test Updated change log.

WebKit Review Bot

Comment 3 2011-04-22 15:27:21 PDT

Attachment 90778 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/Scripts/webkitpy..." exit_code: 1 Tools/Scripts/webkitpy/common/assert_dictionaries_equal_mixin.py:7: trailing whitespace [pep8/W291] [5] Tools/Scripts/webkitpy/common/assert_dictionaries_equal_mixin.py:12: trailing whitespace [pep8/W291] [5] Tools/Scripts/webkitpy/common/assert_dictionaries_equal_mixin.py:18: expected 2 blank lines, found 1 [pep8/E302] [5] Tools/Scripts/webkitpy/common/checkout/scm_unittest.py:712: whitespace before '}' [pep8/E202] [5] Total errors found: 4 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.

WebKit Review Bot

Comment 4 2011-04-22 15:28:00 PDT

Attachment 90779 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/Scripts/webkitpy..." exit_code: 1 Tools/Scripts/webkitpy/common/assert_dictionaries_equal_mixin.py:7: trailing whitespace [pep8/W291] [5] Tools/Scripts/webkitpy/common/assert_dictionaries_equal_mixin.py:12: trailing whitespace [pep8/W291] [5] Tools/Scripts/webkitpy/common/assert_dictionaries_equal_mixin.py:18: expected 2 blank lines, found 1 [pep8/E302] [5] Tools/Scripts/webkitpy/common/checkout/scm_unittest.py:712: whitespace before '}' [pep8/E202] [5] Total errors found: 4 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.

Daniel Bates

Comment 5 2011-04-22 15:32:21 PDT

Created attachment 90782 [details] Patch and unit tests

WebKit Review Bot

Comment 6 2011-04-22 15:34:25 PDT

Attachment 90782 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/Scripts/webkitpy..." exit_code: 1 Tools/Scripts/webkitpy/common/checkout/scm_unittest.py:712: whitespace before '}' [pep8/E202] [5] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.

Daniel Bates

Comment 7 2011-04-22 16:47:47 PDT

Created attachment 90802 [details] Patch and unit tests Updated patch so that it applies.

WebKit Review Bot

Comment 8 2011-04-22 16:49:29 PDT

Attachment 90802 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/Scripts/webkitpy..." exit_code: 1 Tools/Scripts/webkitpy/common/checkout/scm_unittest.py:764: whitespace before '}' [pep8/E202] [5] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.

Daniel Bates

Comment 9 2011-04-22 16:57:17 PDT

Created attachment 90804 [details] Patch and unit test

Daniel Bates

Comment 10 2011-04-22 17:01:43 PDT

Created attachment 90806 [details] Patch and unit test

Note You need to log in before you can comment on or make changes to this bug.