Bug 59238 – [EFL] Eliminate error when setting icon database path for open database.

• Component: WebKit EFL
• Status: RESOLVED DUPLICATE

[Lukasz Slachciak]

When running EWebLauncher on debug build there is an error:

ERROR: Attempt to reopen the IconDatabase which is already open.  Must close it first.
/home/lukasz/sources/WebKit/WebKit/Source/WebCore/loader/icon/IconDatabase.cpp(127) : virtual bool WebCore::IconDatabase::open(const WTF::String&, const WTF::String&)

This is because ewk_settings_icon_database_path_set i called twice. 
To eliminate such problems I modified ewk_settings_icon_database_path_set to close already open icon db if new path is given.
Please review attached patch.

[Lukasz Slachciak]

Created attachment 90769 [details]
icon database error fix

[Eric Seidel (no email)]

Comment on attachment 90769 [details]
icon database error fix

Looks OK.

[Eric Seidel (no email)]

Bradee is the icon database expert, but I think this is EFL specific.

[Brady Eidson]

The error is valid.  It is extremely wasteful and problematic for the client to manage icon retain counts properly if the database is closed/reopened/moved after initial launch.

This does, indeed, seem EFL specific, so they can fix it however they'd like.  I would recommend not wastefully calling this method twice.  :)

[Eric Seidel (no email)]

Comment on attachment 90769 [details]
icon database error fix

Seems like Bradee thinks this is a bad idea.

[Tomasz Morawski]

*** Bug 60148 has been marked as a duplicate of this bug. ***

[Raphael Kubo da Costa (:rakuco)]

The proposed patch in bug 60361 also stops calling the method twice, as recommended by comment #4, so it would also fix this bug.

[Lukasz Slachciak]

I agree that Tomasz's bug 60361 fixes this issue and this is ok for me.
But according to comment #4 - if we can't call ewk_settings_icon_database_path_set twice, we should remove this function from API. What do you think?

[Lukasz Slachciak]

*** This bug has been marked as a duplicate of bug 60361 ***

[Raphael Kubo da Costa (:rakuco)]

(In reply to comment #8)
> But according to comment #4 - if we can't call ewk_settings_icon_database_path_set twice, we should remove this function from API. What do you think?

I'd recommend going this way only after some discussion with people more acquainted with this part of the code in WebCore -- at least the GTK+ and Qt ports do almost the same thing in their code, for example.