REGRESSION (r82185): iframe not displayed after navigation back to cached page

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[Beth Dakin]

* SUMMARY
After navigating back to a page in the page cache with an iframe, the iframe is not loaded.

* STEPS TO REPRODUCE
1. Navigate to <data:text/html,%3ciframe%20src=%22http://webkit.org/%22%3E%3C/iframe%3E>
2. Navigate in the same tab to <about:blank>
3. Go back

* RESULTS
The iframe is now empty

* NOTES
Only happens if the back/forward cache is enabled.

This is a regression from http://trac.webkit.org/changeset/82185

Patch forthcoming!

<rdar://problem/9323763>

[Beth Dakin]

Created attachment 90745 [details]
Patch

I made a test that works for this in Safari, but it is not a valid DRT test since it passes in DRT even without my patch.

[Maciej Stachowiak]

Comment on attachment 90745 [details]
Patch

What's different about DRT? IS it the fact that DRT doesn't use overlay scrollers? I'd suggest at least adding it as a manual test so we don't forget about it. r=me

[Beth Dakin]

(In reply to comment #2)
> (From update of attachment 90745 [details])
> What's different about DRT? IS it the fact that DRT doesn't use overlay scrollers? I'd suggest at least adding it as a manual test so we don't forget about it. r=me

No, the bug occurs with all types of scrollbars. For some reason DRT just lays out and paints the iframe after going back to the page, which is not true in Safar/WebKit without this patch. I thought it would at least work as a pixel test, but it does not. There must be something sufficiently different about about DRT's back mechanism and "back" in the browser that causes the necessary layout to happen. I can add it as a manual test though.

[Beth Dakin]

Do we have manual tests checked in anymore? I can't seem to find them.

[Beth Dakin]

Committed the change with revision 84688. Not sure if there's a place for my still-manual test, so I will just hold onto it for now.

[Alexey Proskuryakov]

> Do we have manual tests checked in anymore? I can't seem to find them.

Source/WebCore/manual-tests. Not that anyone ever runs those.

[Beth Dakin]

(In reply to comment #6)
> > Do we have manual tests checked in anymore? I can't seem to find them.
> 
> Source/WebCore/manual-tests. Not that anyone ever runs those.

WebCore! That's where they are hiding. Yeah, it's not super useful, but I will check it in there anyway.

[Beth Dakin]

Manual test added with revision 84694.

[WebKit Review Bot]

http://trac.webkit.org/changeset/84688 might have broken SnowLeopard Intel Release (Build)

[WebKit Review Bot]

http://trac.webkit.org/changeset/84694 might have broken SnowLeopard Intel Release (Build)

[WebKit Review Bot]

http://trac.webkit.org/changeset/84695 might have broken SnowLeopard Intel Release (Build)