Bug 59213 – rounded corners don't looks smooth when background-image is a gradient

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[Vicki Murley]

Created attachment 90729 [details]
test cases for buttons with gradients as background images

Follow up to https://bugs.webkit.org/show_bug.cgi?id=21819

When an element has rounded corners and the uses a gradient as the background image, the rounded edges don't look smooth.  Some color, from the gradient or the background color, is bleeding through the edges.

Attached two examples.  The first is the same example attached to https://bugs.webkit.org/show_bug.cgi?id=21819, plus a gradient.  The second is a slightly more complicated mock-up of iPhone-style buttons.

[Simon Fraser (smfr)]

Created attachment 90730 [details]
Reduction

[Simon Fraser (smfr)]

Created attachment 90736 [details]
Patch

Comment on attachment 90736 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=90736&action=review

> Source/WebCore/rendering/RenderBoxModelObject.cpp:584
> +    adjustedRect.inflateX(-ceilf(1.0f / contextScale.width()));
> +    adjustedRect.inflateY(-ceilf(1.0f / contextScale.height()));

Drop the .0f

[Simon Fraser (smfr)]

http://trac.webkit.org/changeset/84664