Bug 59210 – WebKit2: Stop Responsiveness Timer when WebPageProxy closes or WebProcess crashes

• Component: WebKit2
• Status: RESOLVED FIXED

[Brian Weinstein]

We should stop the responsiveness timer when a WebPageProxy closes or when the WebProcess crashes.

[Brian Weinstein]

Created attachment 90721 [details]
[PATCH] Fix

[Sam Weinig]

Comment on attachment 90721 [details]
[PATCH] Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=90721&action=review

> Source/WebKit2/UIProcess/WebPageProxy.cpp:182
> +    process()->responsivenessTimer()->stop();

This should probably be in close(), not the destructor.

[Brian Weinstein]

Created attachment 90723 [details]
[PATCH] Fix v2

[Sam Weinig]

Comment on attachment 90723 [details]
[PATCH] Fix v2

View in context: https://bugs.webkit.org/attachment.cgi?id=90723&action=review

> Source/WebKit2/UIProcess/WebPageProxy.cpp:357
> +    process()->responsivenessTimer()->stop();

The remove webpage thing call should be last, please move this above the call to process()->send(Messages::WebPage::Close(), m_pageID) to keep consistency.

[Brian Weinstein]

Landed in r84643.

[Adam Roben (:aroben)]

For posterity's sake:

The issue this was trying to fix was: clicking the "close" button in the docked Web Inspector would cause the UI process to think the web process had become unresponsive. Our theory for why this was happening was that the Web Inspector's WebPage wasn't having time to send the DidHandleEvent message back to the UI process before it was closed. Thus we tried to fix the issue by always stopping the responsiveness timer whenever a WebPage gets closed.