Bug 59176

Summary:

Don't do manually style resolution for SVGElements with renderer

Product:

WebKit

Reporter:

Dirk Schulze <krit>

Component:

SVG

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

rwlbuis, zimmermann

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	zimmermann: review+

Description Dirk Schulze 2011-04-21 22:20:19 PDT

https://bugs.webkit.org/show_bug.cgi?id=52513#c16

Comment 1 Dirk Schulze 2011-04-21 22:27:44 PDT

Created attachment 90670 [details]
Patch

Comment 2 Nikolas Zimmermann 2011-04-22 05:36:31 PDT

Comment on attachment 90670 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=90670&action=review

Excellent cleanup, r=me.

> Source/WebCore/ChangeLog:11
> +        Don't do manually style resolution for SVGElements with renderer. Instead get RenderStyle
> +        from the renderer.

Don't resolve style manually, instead ask the RenderObject for its style.

> Source/WebCore/ChangeLog:13
> +        Removed SVG element names from SVG attribute list.

Cleanup svgattrs.in, some SVG element names were accidently listed there as attributes.

Comment 3 Rob Buis 2011-05-18 17:03:16 PDT

Reminder for Dirk, seems this is ready to land!
Cheers,

Rob.

Comment 4 Dirk Schulze 2011-05-18 23:20:45 PDT

Oops! I'll land it later today.

Comment 5 Dirk Schulze 2011-05-22 04:55:12 PDT

Committed r87028: <http://trac.webkit.org/changeset/87028>