Bug 59175

Summary: Need to support authentication for downloads in WebKit2 on Windows
Product: WebKit Reporter: Jon Honeycutt <jhoneycutt>
Component: WebKit2Assignee: Jon Honeycutt <jhoneycutt>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, buildbot, eric, webkit.review.bot
Priority: P2 Keywords: InRadar, PlatformOnly
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows 7   
Attachments:
Description Flags
Patch mjs: review+

Description Jon Honeycutt 2011-04-21 22:06:25 PDT 
Downloads in WK2 on Windows need authentication support.

<rdar://problem/9206151>
<rdar://problem/8958280>
Comment 1 Jon Honeycutt 2011-04-21 22:25:34 PDT 
Created attachment 90669 [details]
Patch
Comment 2 WebKit Review Bot 2011-04-21 22:27:56 PDT 
Attachment 90669 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1

Source/WebKit2/WebProcess/Downloads/DownloadAuthenticationClient.h:34:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Maciej Stachowiak 2011-04-21 22:33:59 PDT 
Comment on attachment 90669 [details]
Patch

r=me
Comment 4 Build Bot 2011-04-21 23:01:32 PDT 
Attachment 90669 [details] did not build on win:
Build output: http://queues.webkit.org/results/8495307
Comment 5 Jon Honeycutt 2011-04-22 00:42:46 PDT 
Landed in http://trac.webkit.org/changeset/84610.
Comment 6 WebKit Review Bot 2011-04-22 01:45:59 PDT 
http://trac.webkit.org/changeset/84610 might have broken WinCairo Debug (Build)