Bug 59132 – Rebaseline tests which look different due to a change in skia gradient calculations.

• Component: New Bugs
• Status: RESOLVED FIXED

Rebaseline tests which look different due to a change in skia gradient calculations.

Created attachment 90586 [details]
Patch

[Stephen White]

Looks good (unofficially).

[Kenneth Russell]

Comment on attachment 90586 [details]
Patch

Sounds fine.

[WebKit Commit Bot]

Comment on attachment 90586 [details]
Patch

Rejecting attachment 90586 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=eseidel-cq-sf', 'ap..." exit_code: 2

Last 500 characters of output:
nts/background-clipped-expected.checksum	(revision 84507)
|+++ LayoutTests/platform/chromium-win/fast/gradients/background-clipped-expected.checksum	(working copy)
--------------------------
No file to patch.  Skipping patch.
1 out of 1 hunk ignored
patching file LayoutTests/platform/chromium/test_expectations.txt
Hunk #1 succeeded at 3515 with fuzz 2 (offset 9 lines).

Failed to run "[u'/Projects/CommitQueue/Tools/Scripts/svn-apply', u'--reviewer', u'Kenneth Russell', u'--force']" exit_code: 1

Full output: http://queues.webkit.org/results/8496161

Created attachment 91332 [details]
Patch

[Kenneth Russell]

Comment on attachment 91332 [details]
Patch

Looks fine as long as they've been tested.

[Eric Seidel (no email)]

Why doesnt' pretty-patch show image diffs for these?

[Tony Chang]

(In reply to comment #7)
> Why doesnt' pretty-patch show image diffs for these?

Does it normally?  There images being removed aren't in the svn created diff so I'm not sure how pretty-patch would show an image diff.

git sometimes includes the file being deleted (some sort of binary diff format), so some git produced patches have the image being removed.

(In reply to comment #7)
> Why doesnt' pretty-patch show image diffs for these?

Not sure.  I am new to the tools.  I did run the new diff tool in skia to find the differences, though, and it shows the same differences I expected (based on using the rebaseline server).

[WebKit Commit Bot]

Comment on attachment 91332 [details]
Patch

Rejecting attachment 91332 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-3', 'apply-..." exit_code: 2

Last 500 characters of output:
apply', u'--reviewer', u'Kenneth Russell', u'--..." exit_code: 1

Parsed 18 diffs from patch file(s).
patching file LayoutTests/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file LayoutTests/platform/chromium/test_expectations.txt
Hunk #1 FAILED at 3485.
1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/chromium/test_expectations.txt.rej

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Kenneth Russell', u'--..." exit_code: 1

Full output: http://queues.webkit.org/results/8516297

[Kenneth Russell]

Sorry...the test_expectations.txt file seems to change pretty quickly.

If you can rebaseline this against TOT I can help you land it by hand tomorrow.

Created attachment 91488 [details]
Patch

(In reply to comment #11)
> Sorry...the test_expectations.txt file seems to change pretty quickly.
> 
> If you can rebaseline this against TOT I can help you land it by hand tomorrow.

Thanks.  Just uploaded again.

[Steve Block]

Comment on attachment 91488 [details]
Patch

r=me

[WebKit Commit Bot]

Comment on attachment 91488 [details]
Patch

Clearing flags on attachment: 91488

Committed r85201: <http://trac.webkit.org/changeset/85201>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.