Bug 59132

Summary: Rebaseline tests which look different due to a change in skia gradient calculations.
Product: WebKit Reporter: scroggo
Component: New BugsAssignee: scroggo
Status: RESOLVED FIXED    
Severity: Normal CC: aroben, commit-queue, dbates, dpranke, eric, kbr, krit, ojan, reed, scroggo, senorblanco, tony
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description scroggo 2011-04-21 13:07:41 PDT
Rebaseline tests which look different due to a change in skia gradient calculations.
Comment 1 scroggo 2011-04-21 13:09:02 PDT
Created attachment 90586 [details]
Patch
Comment 2 Stephen White 2011-04-21 13:19:35 PDT
Looks good (unofficially).
Comment 3 Kenneth Russell 2011-04-21 13:31:28 PDT
Comment on attachment 90586 [details]
Patch

Sounds fine.
Comment 4 WebKit Commit Bot 2011-04-21 16:26:10 PDT
Comment on attachment 90586 [details]
Patch

Rejecting attachment 90586 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=eseidel-cq-sf', 'ap..." exit_code: 2

Last 500 characters of output:
nts/background-clipped-expected.checksum	(revision 84507)
|+++ LayoutTests/platform/chromium-win/fast/gradients/background-clipped-expected.checksum	(working copy)
--------------------------
No file to patch.  Skipping patch.
1 out of 1 hunk ignored
patching file LayoutTests/platform/chromium/test_expectations.txt
Hunk #1 succeeded at 3515 with fuzz 2 (offset 9 lines).

Failed to run "[u'/Projects/CommitQueue/Tools/Scripts/svn-apply', u'--reviewer', u'Kenneth Russell', u'--force']" exit_code: 1

Full output: http://queues.webkit.org/results/8496161
Comment 5 scroggo 2011-04-27 13:14:38 PDT
Created attachment 91332 [details]
Patch
Comment 6 Kenneth Russell 2011-04-27 13:49:07 PDT
Comment on attachment 91332 [details]
Patch

Looks fine as long as they've been tested.
Comment 7 Eric Seidel (no email) 2011-04-27 13:50:46 PDT
Why doesnt' pretty-patch show image diffs for these?
Comment 8 Tony Chang 2011-04-27 14:06:51 PDT
(In reply to comment #7)
> Why doesnt' pretty-patch show image diffs for these?

Does it normally?  There images being removed aren't in the svn created diff so I'm not sure how pretty-patch would show an image diff.

git sometimes includes the file being deleted (some sort of binary diff format), so some git produced patches have the image being removed.
Comment 9 scroggo 2011-04-27 14:20:40 PDT
(In reply to comment #7)
> Why doesnt' pretty-patch show image diffs for these?

Not sure.  I am new to the tools.  I did run the new diff tool in skia to find the differences, though, and it shows the same differences I expected (based on using the rebaseline server).
Comment 10 WebKit Commit Bot 2011-04-27 20:59:34 PDT
Comment on attachment 91332 [details]
Patch

Rejecting attachment 91332 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-3', 'apply-..." exit_code: 2

Last 500 characters of output:
apply', u'--reviewer', u'Kenneth Russell', u'--..." exit_code: 1

Parsed 18 diffs from patch file(s).
patching file LayoutTests/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file LayoutTests/platform/chromium/test_expectations.txt
Hunk #1 FAILED at 3485.
1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/chromium/test_expectations.txt.rej

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Kenneth Russell', u'--..." exit_code: 1

Full output: http://queues.webkit.org/results/8516297
Comment 11 Kenneth Russell 2011-04-27 21:21:21 PDT
Sorry...the test_expectations.txt file seems to change pretty quickly.

If you can rebaseline this against TOT I can help you land it by hand tomorrow.
Comment 12 scroggo 2011-04-28 07:25:47 PDT
Created attachment 91488 [details]
Patch
Comment 13 scroggo 2011-04-28 07:27:17 PDT
(In reply to comment #11)
> Sorry...the test_expectations.txt file seems to change pretty quickly.
> 
> If you can rebaseline this against TOT I can help you land it by hand tomorrow.

Thanks.  Just uploaded again.
Comment 14 Steve Block 2011-04-28 08:08:51 PDT
Comment on attachment 91488 [details]
Patch

r=me
Comment 15 WebKit Commit Bot 2011-04-28 10:01:47 PDT
Comment on attachment 91488 [details]
Patch

Clearing flags on attachment: 91488

Committed r85201: <http://trac.webkit.org/changeset/85201>
Comment 16 WebKit Commit Bot 2011-04-28 10:01:57 PDT
All reviewed patches have been landed.  Closing bug.