Bug 59129

Summary: [chromium] Texture manager textures don't always get unreserved
Product: WebKit Reporter: Vangelis Kokkevis <vangelis>
Component: WebCore Misc.Assignee: Vangelis Kokkevis <vangelis>
Status: RESOLVED FIXED    
Severity: Normal CC: enne, jamesr
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Patch jamesr: review+

Vangelis Kokkevis
Reported 2011-04-21 12:22:13 PDT
Currently layers reserve textures in the texture manager when their contents are painted and unreserve after the layer has been drawn. Since the compositor can skip layers at draw time (e.g. when the layer is outside the clip rect) some textures are left reserved. Over time they add to the memory (VRAM) bloat. The debug chromium builds currently assert when a texture is reserved twice (which is an indication that the texture was not unreserved after the previous draw). An easy repro case for the assert is loading this page: http://www.satine.org/research/webkit/snowleopard/snowstack.html
Attachments
Patch (16.85 KB, patch)
2011-04-21 12:27 PDT, Vangelis Kokkevis 		jamesr: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Vangelis Kokkevis
Comment 1 2011-04-21 12:27:52 PDT
Created attachment 90577 [details] Patch
James Robinson
Comment 2 2011-04-21 12:58:37 PDT
Comment on attachment 90577 [details] Patch Looks good. I'm pretty sure this will conflict with enne's upload patch.
Vangelis Kokkevis
Comment 3 2011-04-21 18:05:58 PDT
Committed r84582: <http://trac.webkit.org/changeset/84582>
Note You need to log in before you can comment on or make changes to this bug.