Summary: | ValidateChangeLogs doesn't work on SVN | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Adam Barth <abarth> | ||||||
Component: | New Bugs | Assignee: | Adam Barth <abarth> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, eric, mdelaney7, ojan | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Other | ||||||||
OS: | OS X 10.5 | ||||||||
Attachments: |
|
Description
Adam Barth
2011-04-21 10:42:35 PDT
Created attachment 90555 [details]
Patch
Comment on attachment 90555 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=90555&action=review > Tools/Scripts/webkitpy/tool/steps/validatechangelogs.py:64 > + # We diff the ChangeLogs directly because svn-create-patch doesn't > + # always tell the truth about where the new ChangeLog entry is in > + # the file. I would have written this more like: # Diff ChangeLogs directly because svn-create-patch will move ChangeLog entries to the # top automatically, defeating our validation here. Aka, more substance, less frill. :) (Not that I don't like the frill.) > Tools/Scripts/webkitpy/tool/steps/validatechangelogs.py:65 > + diff = self._tool.scm().diff_for_file(filename) We may want to diff multiple files at once. Not sure what the perf characteristics of SVN are. Created attachment 90561 [details]
Patch for landing
Comment on attachment 90561 [details] Patch for landing Clearing flags on attachment: 90561 Committed r84549: <http://trac.webkit.org/changeset/84549> All reviewed patches have been landed. Closing bug. Committed r84560: <http://trac.webkit.org/changeset/84560> |