|Summary:||ValidateChangeLogs doesn't work on SVN|
|Product:||WebKit||Reporter:||Adam Barth <abarth>|
|Component:||New Bugs||Assignee:||Adam Barth <abarth>|
|Severity:||Normal||CC:||commit-queue, eric, mdelaney7, ojan|
|Version:||528+ (Nightly build)|
|OS:||OS X 10.5|
Description Adam Barth 2011-04-21 10:42:35 PDT
ValidateChangeLogs doesn't work on SVN
Comment 2 Eric Seidel (no email) 2011-04-21 10:50:26 PDT
Comment on attachment 90555 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=90555&action=review > Tools/Scripts/webkitpy/tool/steps/validatechangelogs.py:64 > + # We diff the ChangeLogs directly because svn-create-patch doesn't > + # always tell the truth about where the new ChangeLog entry is in > + # the file. I would have written this more like: # Diff ChangeLogs directly because svn-create-patch will move ChangeLog entries to the # top automatically, defeating our validation here. Aka, more substance, less frill. :) (Not that I don't like the frill.) > Tools/Scripts/webkitpy/tool/steps/validatechangelogs.py:65 > + diff = self._tool.scm().diff_for_file(filename) We may want to diff multiple files at once. Not sure what the perf characteristics of SVN are.
Comment 4 WebKit Commit Bot 2011-04-21 15:01:11 PDT
Comment on attachment 90561 [details] Patch for landing Clearing flags on attachment: 90561 Committed r84549: <http://trac.webkit.org/changeset/84549>
Comment 5 WebKit Commit Bot 2011-04-21 15:01:15 PDT
All reviewed patches have been landed. Closing bug.