Bug 59057

Summary:

Removed a use of markDOMObjectWrapper: CSS Object Model

Product:

WebKit

Reporter:

Geoffrey Garen <ggaren>

Component:

New Bugs

Assignee:

Geoffrey Garen <ggaren>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, buildbot, eric, oliver, webkit-ews, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	oliver: review+

Description Geoffrey Garen 2011-04-20 18:28:38 PDT

Removed a use of markDOMObjectWrapper: CSS Object Model

Comment 1 Geoffrey Garen 2011-04-20 18:59:50 PDT

Created attachment 90475 [details]
Patch

Comment 2 Early Warning System Bot 2011-04-20 19:21:07 PDT

Attachment 90475 [details] did not build on qt:
Build output: http://queues.webkit.org/results/8474869

Comment 3 Oliver Hunt 2011-04-20 20:34:15 PDT

Comment on attachment 90475 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=90475&action=review

r=me, but fix efl + qt builds

> Source/WebCore/bindings/js/JSCSSStyleDeclarationCustom.cpp:223
> +    cssValueRoots().add(cssValue.get(), root(impl())); // Balanced by JSCSSValueOwner::finalize().

So much sadness

Comment 4 Oliver Hunt 2011-04-20 20:36:56 PDT

I think these custom toJS functions can be autogenerated -- just need a flag that says NeedsWeakHandleDoohicky or somesuch as you can auto generate the correct call to wrap..

Comment 5 Build Bot 2011-04-20 20:43:12 PDT

Attachment 90475 [details] did not build on win:
Build output: http://queues.webkit.org/results/8472895

Comment 6 Geoffrey Garen 2011-04-21 11:29:17 PDT

Committed r84527: <http://trac.webkit.org/changeset/84527>

Comment 7 WebKit Review Bot 2011-04-21 11:34:11 PDT

http://trac.webkit.org/changeset/84527 might have broken EFL Linux Release (Build)