Bug 59024

Summary: only return false if we actually in a skia-gpu accelerated canvas for isNativeFontRenderingAllowed
Product: WebKit Reporter: Mike Reed <reed>
Component: New BugsAssignee: Mike Reed <reed>
Status: RESOLVED FIXED    
Severity: Normal CC: bsalomon, commit-queue, kbr, reed, steveblock, vangelis
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from cr-jail-7 none

Mike Reed
Reported 2011-04-20 14:16:29 PDT
only return false if we actually in a skia-gpu accelerated canvas for isNativeFontRenderingAllowed
Attachments
Patch (1.63 KB, patch)
2011-04-20 14:20 PDT, Mike Reed 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from cr-jail-7 (202.94 KB, application/zip)
2011-04-21 13:00 PDT, WebKit Commit Bot 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Mike Reed
Comment 1 2011-04-20 14:20:05 PDT
Created attachment 90410 [details] Patch
Kenneth Russell
Comment 2 2011-04-20 14:32:52 PDT
Comment on attachment 90410 [details] Patch OK. Let's get this fix in quickly.
WebKit Commit Bot
Comment 3 2011-04-21 13:00:38 PDT
Comment on attachment 90410 [details] Patch Rejecting attachment 90410 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-7', 'build-..." exit_code: 2 Last 500 characters of output: ests/xmlhttprequest ................................................................................................................................................................................ http/tests/xmlhttprequest/web-apps ............... http/tests/xmlhttprequest/workers ........... http/tests/xmlviewer . http/tests/xmlviewer/dumpAsText ............ 767.94s total testing time 23345 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 14 test cases (<1%) had stderr output Full output: http://queues.webkit.org/results/8496101
WebKit Commit Bot
Comment 4 2011-04-21 13:00:42 PDT
Created attachment 90584 [details] Archive of layout-test-results from cr-jail-7 The attached test failures were seen while running run-webkit-tests on the commit-queue. Bot: cr-jail-7 Port: Mac Platform: Mac OS X 10.6.6
Kenneth Russell
Comment 5 2011-04-21 13:03:36 PDT
Comment on attachment 90410 [details] Patch The commit queue failure looks completely unrelated. Trying again.
WebKit Commit Bot
Comment 6 2011-04-21 14:09:53 PDT
Comment on attachment 90410 [details] Patch Clearing flags on attachment: 90410 Committed r84545: <http://trac.webkit.org/changeset/84545>
WebKit Commit Bot
Comment 7 2011-04-21 14:09:58 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.