Bug 59016

Summary: put unexpected passes into their own table
Product: WebKit Reporter: Ojan Vafai <ojan>
Component: New BugsAssignee: Ojan Vafai <ojan>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch tony: review+

Description Ojan Vafai 2011-04-20 12:11:59 PDT
put unexpected passes into their own table
Comment 1 Ojan Vafai 2011-04-20 12:14:08 PDT
Created attachment 90382 [details]
Patch
Comment 2 Eric Seidel (no email) 2011-04-20 12:17:39 PDT
Comment on attachment 90382 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=90382&action=review

> Tools/Scripts/webkitpy/layout_tests/layout_package/json_results.html:11
> +tbody tr:first-of-type:hover {

I'm confused why you want to match the first tr in the table body and only on hover.
Comment 3 Ojan Vafai 2011-04-20 12:20:42 PDT
(In reply to comment #2)
> (From update of attachment 90382 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=90382&action=review
> 
> > Tools/Scripts/webkitpy/layout_tests/layout_package/json_results.html:11
> > +tbody tr:first-of-type:hover {
> 
> I'm confused why you want to match the first tr in the table body and only on hover.

This change is actually just so that we don't change opacity when you hover over the thead.

We put each row in it's own tbody. Then we use a second tr for the expected results. We don't want to change the opacity of the expected results on hover. So the HTML looks something like the following:

<table>
  <thead>...</thead>
  <tbody>
    <tr>test name + links to results</tr>
    <tr>iframes/imgs to the inline results</tr>
  </tbody>
  <tbody>
    <tr>test name + links to results</tr>
    <tr>iframes/imgs to the inline results</tr>
  </tbody>
</table>

This way, when we sort the rows, we can sort the tbody elements and the inline results sort along with the test + result links.
Comment 4 Ojan Vafai 2011-04-20 15:26:08 PDT
Comment on attachment 90382 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=90382&action=review

>>> Tools/Scripts/webkitpy/layout_tests/layout_package/json_results.html:11
>>> +tbody tr:first-of-type:hover {
>> 
>> I'm confused why you want to match the first tr in the table body and only on hover.
> 
> This change is actually just so that we don't change opacity when you hover over the thead.
> 
> We put each row in it's own tbody. Then we use a second tr for the expected results. We don't want to change the opacity of the expected results on hover. So the HTML looks something like the following:
> 
> <table>
>   <thead>...</thead>
>   <tbody>
>     <tr>test name + links to results</tr>
>     <tr>iframes/imgs to the inline results</tr>
>   </tbody>
>   <tbody>
>     <tr>test name + links to results</tr>
>     <tr>iframes/imgs to the inline results</tr>
>   </tbody>
> </table>
> 
> This way, when we sort the rows, we can sort the tbody elements and the inline results sort along with the test + result links.

I can cut this or do this in a separate patch if you need.
Comment 5 Tony Chang 2011-04-21 10:01:02 PDT
Comment on attachment 90382 [details]
Patch

Ojan says he has a version that is rebased with the globalState() change.
Comment 6 Ojan Vafai 2011-04-21 10:36:17 PDT
Created attachment 90554 [details]
Patch
Comment 7 Ojan Vafai 2011-04-21 10:43:37 PDT
Committed r84518: <http://trac.webkit.org/changeset/84518>
Comment 8 WebKit Review Bot 2011-04-21 11:24:30 PDT
http://trac.webkit.org/changeset/84518 might have broken Qt Linux ARMv7 Release and Qt Windows 32-bit Debug