Summary: | arc() should add a circle to the path when start and end angles are far enough apart | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Matthew Delaney <mdelaney7> | ||||||||
Component: | Canvas | Assignee: | Matthew Delaney <mdelaney7> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | cmarrin, mdelaney7, simon.fraser | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | PC | ||||||||||
OS: | OS X 10.5 | ||||||||||
Attachments: |
|
Description
Matthew Delaney
2011-04-19 15:32:09 PDT
Created attachment 90359 [details]
Patch
Comment on attachment 90359 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=90359&action=review > Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp:856 > + if (anticlockwise && sa - ea >= 2.0f * piFloat) { The coding style guidelines says that you should just write this as 2 * piFloat. > Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp:859 > + m_path.addArc(FloatPoint(x, y), r, sa, sa - piFloat, anticlockwise); > + m_path.addArc(FloatPoint(x, y), r, sa - piFloat, sa, anticlockwise); This can be done as a single 2π arc. Created attachment 90402 [details]
Patch
Created attachment 90411 [details]
Patch
Comment on attachment 90411 [details]
Patch
r=me
|