Bug 58930

Summary:

Accessibility tree should not contain duplicate child nodes.

Product:

WebKit

Reporter:

Chris Guillory <ctguil>

Component:

Accessibility

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cfleizach, webkit.review.bot

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Layout Test	none
Patch	none

Chris Guillory

Reported 2011-04-19 15:06:04 PDT

Created attachment 90262 [details] Layout Test The accessibility tree can incorrectly list the same node as a child more than once. This can lead to undefined behavior.

Attachments
Layout Test (1.82 KB, patch) 2011-04-19 15:06 PDT, Chris Guillory	no flags	Details Formatted Diff Diff
Patch (2.49 KB, patch) 2011-09-12 21:28 PDT, Dominic Mazzoni	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Chris Guillory

Comment 1 2011-04-19 15:07:15 PDT

Comment on attachment 90262 [details] Layout Test >Index: LayoutTests/accessibility/duplicate-child-nodes.html >=================================================================== >--- LayoutTests/accessibility/duplicate-child-nodes.html (revision 0) >+++ LayoutTests/accessibility/duplicate-child-nodes.html (revision 0) >@@ -0,0 +1,32 @@ >+<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN"> >+<html> >+<head> >+<link rel="stylesheet" href="../fast/js/resources/js-test-style.css"> >+<script> >+ var successfullyParsed = false; >+</script> >+<script src="../fast/js/resources/js-test-pre.js"></script> >+</head> >+<body> >+ >+<em><code ><h4 ></em> >+ >+<p id="description"></p> >+<div id="console"></div> >+ >+<script> >+ description("Child nodes should not be duplicated in the accessibility tree."); >+ >+ if (window.accessibilityController) { >+ document.body.focus(); >+ var webArea = accessibilityController.focusedElement; >+ if (webArea.childrenCount > 1) >+ shouldBe("webArea.childAtIndex(0).isEqual(webArea.childAtIndex(1))", "false"); >+ } >+ >+ successfullyParsed = true; >+</script> >+ >+<script src="../fast/js/resources/js-test-post.js"></script> >+</body> >+</html>

chris fleizach

Comment 2 2011-04-19 18:20:05 PDT

<rdar://problem/9309623>

Dominic Mazzoni

Comment 3 2011-09-12 21:28:25 PDT

Created attachment 107139 [details] Patch

chris fleizach

Comment 4 2011-09-12 22:56:49 PDT

Comment on attachment 107139 [details] Patch r=me thanks

WebKit Review Bot

Comment 5 2011-09-12 23:10:01 PDT

Comment on attachment 107139 [details] Patch Clearing flags on attachment: 107139 Committed r95018: <http://trac.webkit.org/changeset/95018>

WebKit Review Bot

Comment 6 2011-09-12 23:10:06 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.