Bug 5889

Summary: HTMLNames.* should be generated using make_names.pl
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: DOMAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P4    
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
Bug Depends on: 5887    
Bug Blocks:    
Attachments:
Description Flags
Add an new optional parameter (namespacePrefix) to make_names.pl
none
First attempt
none
Better patch darin: review+

Eric Seidel (no email)
Reported 2005-11-30 03:44:49 PST
HTMLNames.* should be generated using make_names.pl Now that make_names.pl is fully namespace agnostic (5887), we should move HTMLNames.* over to use it. Would mean one less source file in the repository :)
Attachments
Add an new optional parameter (namespacePrefix) to make_names.pl (1.53 KB, patch)
2006-01-03 13:53 PST, Vincent Ricard 		no flags
DetailsFormatted DiffDiff
First attempt (25.24 KB, patch)
2006-05-16 13:33 PDT, Rob Buis 		no flags
DetailsFormatted DiffDiff
Better patch (24.35 KB, patch)
2006-05-17 08:15 PDT, Rob Buis 		darin: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Vincent Ricard
Comment 1 2006-01-03 13:53:48 PST
Created attachment 5456 [details] Add an new optional parameter (namespacePrefix) to make_names.pl This patch should ease the HTMLNames.* generation with make_names.pl
Darin Adler
Comment 2 2006-01-22 10:43:13 PST
Comment on attachment 5456 [details] Add an new optional parameter (namespacePrefix) to make_names.pl OK, looks fine.
Darin Adler
Comment 3 2006-01-22 12:07:02 PST
Comment on attachment 5456 [details] Add an new optional parameter (namespacePrefix) to make_names.pl On second thought, I don't think we should land this change to make_names.pl. Lets just include it along with any other changes needed to use it for non-SVG uses once we actually get that far. So, good, change, but I'm clearing the review flag so it doesn't show up on our "changes to land" list.
Rob Buis
Comment 4 2006-05-16 13:33:34 PDT
Created attachment 8355 [details] First attempt This is my first attempt at fixing the bug. It should be ok for OS X, if there are some hints for the other platforms, I am willing to incorporate fixes for that too ofcourse. Cheers, Rob.
Darin Adler
Comment 5 2006-05-16 13:37:48 PDT
Comment on attachment 8355 [details] First attempt I'd like to see this script be moved out of ksvg2/scripts if we're going to use it for more the SVG. Perhaps it should be in the dom directory. Or maybe we need to start centralizing build-related scripts in a single central directory? I'd like to see the .in file be named HTMLTagNames.in and HTMLAttributeNames.in rather than abbreviated and all lowercase, to match the naming style in the surrounding code. As long as this code doesn't create initialized globals, we should be fine.
Rob Buis
Comment 6 2006-05-17 08:15:00 PDT
Created attachment 8366 [details] Better patch I did the rename plus the diff between old and new HTMLNames.* Cheers, Rob.
Darin Adler
Comment 7 2006-05-17 21:55:49 PDT
Comment on attachment 8366 [details] Better patch Looks good. r=me
Note You need to log in before you can comment on or make changes to this bug.