Summary: | [Qt] Cleanup includepath adjustment for generated files | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Balazs Kelemen <kbalazs> | ||||
Component: | Platform | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abecsi, ossy | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Balazs Kelemen
2011-04-19 01:03:01 PDT
Created attachment 90164 [details]
Patch
Note: I cannot test the standalone_package path, somebody should take a look. Comment on attachment 90164 [details]
Patch
LGTM.
To test-build the standalone_package path:
Tools/Scripts/build-webkit --qt --makeargs=-j24 CONFIG+=standalone_package CONFIG+=webkit2
should do the trick.
I just checked this, declarative and the WK2 Api tests do not build currently on trunk in standalone_package mode, but the library build succeeds.
I also checked your patch, and it works for the library, too. The above issues need another fix, and I'm not even sure whether they need to be built in standalone_package configuration.
Comment on attachment 90164 [details]
Patch
Nice cleanup, r=me.
(In reply to comment #3) > (From update of attachment 90164 [details]) > LGTM. > > To test-build the standalone_package path: > > Tools/Scripts/build-webkit --qt --makeargs=-j24 CONFIG+=standalone_package CONFIG+=webkit2 > > should do the trick. > > I just checked this, declarative and the WK2 Api tests do not build currently on trunk in standalone_package mode, but the library build succeeds. > > I also checked your patch, and it works for the library, too. The above issues need another fix, and I'm not even sure whether they need to be built in standalone_package configuration. Could you file a new bug report to fix standalone_package build? (In reply to comment #5) > (In reply to comment #3) > > (From update of attachment 90164 [details] [details]) > > LGTM. > > > > To test-build the standalone_package path: > > > > Tools/Scripts/build-webkit --qt --makeargs=-j24 CONFIG+=standalone_package CONFIG+=webkit2 > > > > should do the trick. > > > > I just checked this, declarative and the WK2 Api tests do not build currently on trunk in standalone_package mode, but the library build succeeds. > > > > I also checked your patch, and it works for the library, too. The above issues need another fix, and I'm not even sure whether they need to be built in standalone_package configuration. > > Could you file a new bug report to fix standalone_package build? I will test it and file the bug if it is broken. Comment on attachment 90164 [details] Patch Clearing flags on attachment: 90164 Committed r84364: <http://trac.webkit.org/changeset/84364> All reviewed patches have been landed. Closing bug. |