Bug 58844

Summary: [Qt][WK2] Clean up tool-tip/status-bar confusion.
Product: WebKit Reporter: Andreas Kling <kling>
Component: WebKit QtAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2 Keywords: Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: Mac (PowerPC)   
OS: OS X 10.5   
Attachments:
Description Flags
Proposed patch none

Andreas Kling
Reported 2011-04-18 15:46:20 PDT
Tool-tip changes currently emit QWKPage::statusBarMessage() and status bar message changes emit nothing. This is obviously rather backwards. :)
Attachments
Proposed patch (5.95 KB, patch)
2011-04-18 15:48 PDT, Andreas Kling 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2011-04-18 15:48:56 PDT
Created attachment 90107 [details] Proposed patch
WebKit Review Bot
Comment 2 2011-04-18 15:51:15 PDT
Attachment 90107 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1 Source/WebKit2/UIProcess/API/qt/ClientImpl.h:53: The parameter name "page" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 1 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.
Andreas Kling
Comment 3 2011-04-18 16:06:52 PDT
Comment on attachment 90107 [details] Proposed patch Clearing flags on attachment: 90107 Committed r84201: <http://trac.webkit.org/changeset/84201>
Andreas Kling
Comment 4 2011-04-18 16:06:59 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.