Bug 58844

Summary:

[Qt][WK2] Clean up tool-tip/status-bar confusion.

Product:

WebKit

Reporter:

Andreas Kling <kling>

Component:

WebKit Qt

Assignee:

Andreas Kling <kling>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

webkit.review.bot

Priority:

Keywords:

Qt, QtTriaged

Version:

528+ (Nightly build)

Hardware:

Mac (PowerPC)

OS:

OS X 10.5

Attachments:

Description	Flags
Proposed patch	none

Description Andreas Kling 2011-04-18 15:46:20 PDT

Tool-tip changes currently emit QWKPage::statusBarMessage() and status bar message changes emit nothing.
This is obviously rather backwards. :)

Comment 1 Andreas Kling 2011-04-18 15:48:56 PDT

Created attachment 90107 [details]
Proposed patch

Comment 2 WebKit Review Bot 2011-04-18 15:51:15 PDT

Attachment 90107 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1

Source/WebKit2/UIProcess/API/qt/ClientImpl.h:53:  The parameter name "page" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 Andreas Kling 2011-04-18 16:06:52 PDT

Comment on attachment 90107 [details]
Proposed patch

Clearing flags on attachment: 90107

Committed r84201: <http://trac.webkit.org/changeset/84201>

Comment 4 Andreas Kling 2011-04-18 16:06:59 PDT

All reviewed patches have been landed.  Closing bug.