Bug 58832

Summary: Use the proper navigation policy
Product: WebKit Reporter: Sadrul Habib Chowdhury <sadrul>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: UNCONFIRMED    
Severity: Normal CC: abarth, ap, dglazkov, eric
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch abarth: review-

Sadrul Habib Chowdhury
Reported 2011-04-18 14:47:20 PDT
Use the proper navigation policy
Attachments
Patch (2.83 KB, patch)
2011-04-18 14:48 PDT, Sadrul Habib Chowdhury 		no flags
DetailsFormatted DiffDiff
Patch (2.91 KB, patch)
2011-04-19 08:39 PDT, Sadrul Habib Chowdhury 		abarth: review-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Sadrul Habib Chowdhury
Comment 1 2011-04-18 14:48:01 PDT
Created attachment 90096 [details] Patch
Sadrul Habib Chowdhury
Comment 2 2011-04-18 14:49:57 PDT
This fixes a chromium bug: http://crbug.com/71007
Eric Seidel (no email)
Comment 3 2011-04-18 15:18:55 PDT
It's not at all clear what this patch is doing. Please update the ChangeLog to say so. Also, there should be tests for any testable change to WebKit.
Eric Seidel (no email)
Comment 4 2011-04-18 15:19:09 PDT
Comment on attachment 90096 [details] Patch r- for teh above reasons.
Sadrul Habib Chowdhury
Comment 5 2011-04-19 08:39:01 PDT
Created attachment 90206 [details] Patch
Sadrul Habib Chowdhury
Comment 6 2011-04-19 09:18:44 PDT
I am afraid I do not know of a simple test-case to test the problem: the breakage only shows up in the mail-body area in gmail (more details in http://code.google.com/p/chromium/issues/detail?id=71007)
Adam Barth
Comment 7 2011-04-19 15:06:48 PDT
Comment on attachment 90206 [details] Patch We require tests for functional changes. Without a test, this behavior is likely to regress in the future.
Note You need to log in before you can comment on or make changes to this bug.