Bug 5878

Summary: REGRESSION (WebTextRenderer.m r1.201): pointToOffset always takes the CG code path
Product: WebKit Reporter: mitz
Component: Layout and RenderingAssignee: Dave Hyatt <hyatt>
Status: VERIFIED FIXED    
Severity: Normal    
Priority: P1    
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
Attachments:
Description Flags
Add missing return
mjs: review+
regression test
none
expected result for pixel test none

Description mitz 2005-11-29 08:57:26 PST 
WebTextRenderer.m:587:

    if (shouldUseATSU(run))
        ATSU_pointToOffset(self, run, style, x, includePartialGlyphs); // <---- "return" missing!
    return CG_pointToOffset(self, run, style, x, includePartialGlyphs);
Comment 1 mitz 2005-11-29 09:07:24 PST 
Created attachment 4852 [details]
Add missing return
Comment 2 Maciej Stachowiak 2005-11-29 12:23:55 PST 
Comment on attachment 4852 [details]
Add missing return

r=me
Comment 3 Eric Seidel (no email) 2005-11-29 18:56:59 PST 
Is there a way to make a test case which would catch this?  For example clicking somewhere on ATSUI text 
and having the wrong text select?
Comment 4 mitz 2005-11-30 10:49:20 PST 
Created attachment 4880 [details]
regression test
Comment 5 mitz 2005-11-30 10:50:47 PST 
Created attachment 4881 [details]
expected result for pixel test