Bug 5878

Summary: REGRESSION (WebTextRenderer.m r1.201): pointToOffset always takes the CG code path
Product: WebKit Reporter: mitz
Component: Layout and RenderingAssignee: Dave Hyatt <hyatt>
Status: VERIFIED FIXED    
Severity: Normal    
Priority: P1    
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
Attachments:
Description Flags
Add missing return
mjs: review+
regression test
none
expected result for pixel test none

mitz
Reported 2005-11-29 08:57:26 PST
WebTextRenderer.m:587: if (shouldUseATSU(run)) ATSU_pointToOffset(self, run, style, x, includePartialGlyphs); // <---- "return" missing! return CG_pointToOffset(self, run, style, x, includePartialGlyphs);
Attachments
Add missing return (978 bytes, patch)
2005-11-29 09:07 PST, mitz 		mjs: review+
DetailsFormatted DiffDiff
regression test (3.74 KB, patch)
2005-11-30 10:49 PST, mitz 		no flags
DetailsFormatted DiffDiff
expected result for pixel test (19.94 KB, image/png)
2005-11-30 10:50 PST, mitz 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
mitz
Comment 1 2005-11-29 09:07:24 PST
Created attachment 4852 [details] Add missing return
Maciej Stachowiak
Comment 2 2005-11-29 12:23:55 PST
Comment on attachment 4852 [details] Add missing return r=me
Eric Seidel (no email)
Comment 3 2005-11-29 18:56:59 PST
Is there a way to make a test case which would catch this? For example clicking somewhere on ATSUI text and having the wrong text select?
mitz
Comment 4 2005-11-30 10:49:20 PST
Created attachment 4880 [details] regression test
mitz
Comment 5 2005-11-30 10:50:47 PST
Created attachment 4881 [details] expected result for pixel test
Note You need to log in before you can comment on or make changes to this bug.