Summary: | [chromium, win] Multiple failures of shadow rendering layout tests | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Andrey Kosyakov <caseq> | ||||||||
Component: | Text | Assignee: | Mike Reed <reed> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | bsalomon, commit-queue, junov, kbr, reed, senorblanco | ||||||||
Priority: | P1 | Keywords: | LayoutTestFailure, Regression | ||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | PC | ||||||||||
OS: | Windows 7 | ||||||||||
Attachments: |
|
Description
Andrey Kosyakov
2011-04-18 03:01:59 PDT
According to the flakiness dashboard, it started failing at either r83935 or r83936. http://trac.webkit.org/log/?verbose=on&rev=83936&stop_rev=83935 Mike and Brian, over to you. Created attachment 90549 [details]
Patch
When I changed the shadow code before, I incorrectly assumed that the shadow's alpha should be modulated by the fillColor's alpha. Wrong (at least for webkit). This change ignores the fillColor's alpha by overwriting it for the shadow layer (hence the kSrc_Mode). Looks good (unofficially). Nit: Probably better to use C++-style comments (//) for consistency with the rest of the file. There's nothing in the style guide about it, though, so you can feel free to ignore me. :) Comment on attachment 90549 [details]
Patch
Sounds fine. r=me
The commit-queue encountered the following flaky tests while processing attachment 90549 [details]: http/tests/misc/favicon-loads-with-icon-loading-override.html bug 58412 (author: alice.liu@apple.com) http/tests/xmlhttprequest/basic-auth-nouser.html bug 52978 The commit-queue is continuing to process your patch. Comment on attachment 90549 [details] Patch Clearing flags on attachment: 90549 Committed r84535: <http://trac.webkit.org/changeset/84535> All reviewed patches have been landed. Closing bug. Created attachment 90722 [details]
Patch
Reopening to update test_expectations and baseline images Created attachment 90724 [details]
Patch
Comment on attachment 90724 [details]
Patch
OK.
The commit-queue encountered the following flaky tests while processing attachment 90724 [details]: media/video-playbackrate.html bug 58629 (author: eric.carlson@apple.com) http/tests/xmlhttprequest/cross-origin-authorization.html bug 52398 (author: ap@webkit.org) The commit-queue is continuing to process your patch. Comment on attachment 90724 [details] Patch Clearing flags on attachment: 90724 Committed r84663: <http://trac.webkit.org/changeset/84663> All reviewed patches have been landed. Closing bug. |