Summary: | REGRESSION (r84094): Many tests failing assertions in WebCore::localizedString on Windows | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jessie Berlin <jberlin> | ||||
Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | aroben, jberlin, sam, simon.fraser, webkit.review.bot | ||||
Priority: | P2 | Keywords: | LayoutTestFailure, PlatformOnly, Regression | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | Windows 7 | ||||||
Attachments: |
|
Description
Jessie Berlin
2011-04-17 13:05:37 PDT
Here's the assertion: http://trac.webkit.org/browser/trunk/Source/WebCore/platform/win/LocalizedStringsWin.cpp?rev=84087#L82 ASSERT_WITH_MESSAGE(result.get() != notFound, "could not find localizable string %s in bundle", key); (In reply to comment #1) > Here's the assertion: > > http://trac.webkit.org/browser/trunk/Source/WebCore/platform/win/LocalizedStringsWin.cpp?rev=84087#L82 > > ASSERT_WITH_MESSAGE(result.get() != notFound, "could not find localizable string %s in bundle", key); The assertion failure seems to be happening under places like WebCore::imageTitle. Wouldn't it be expected to not find all image titles localized in the webkit bundle? Maybe that assertion needs to removed and replaced with: if (result.get() != notFound) return result.get(); and otherwise let it fall through to the non-cf version? (which just returns the string itself?) Or maybe we shouldn't be trying to localize image titles at all? (In reply to comment #2) > Wouldn't it be expected to not find all image titles localized in the webkit bundle? Yes. But we aren't trying to find all image titles. We're trying to find a format string: "%@ $@x$@ pixels". I had some typos in that format string, but you get the idea. Created attachment 90047 [details]
Proposed Change to fix the update-webkit-localizable-strings script
Attachment 90047 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Tools/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5]
Source/WebKit/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5]
Source/WebCore/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5]
Total errors found: 3 in 4 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 90047 [details] Proposed Change to fix the update-webkit-localizable-strings script Landed in r84158. Build fix in r84159. Fixed in http://trac.webkit.org/changeset/84192 by copying over the proper Localizable.strings file. |