Bug 58702

Summary:

Add layout test to ensure we don't regress clicking when exiting pan scrolling

Product:

WebKit

Reporter:

Daniel Bates <dbates>

Component:

Tools / Tests

Assignee:

Daniel Bates <dbates>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

darin, eric, maxime.britto, zan

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

Windows XP

Attachments:

Description	Flags
Layout test	none
Layout test	abarth: review+, dbates: commit-queue-

Daniel Bates

Reported 2011-04-15 15:25:21 PDT

We should add a layout test for changeset 35434 <http://trac.webkit.org/changeset/35434>.

Attachments
Layout test (6.46 KB, patch) 2011-04-15 20:01 PDT, Daniel Bates	no flags	Details Formatted Diff Diff
Layout test (6.45 KB, patch) 2011-04-15 20:06 PDT, Daniel Bates	abarth: review+ dbates: commit-queue-	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Daniel Bates

Comment 1 2011-04-15 20:01:37 PDT

Created attachment 89906 [details] Layout test I prefer to land this patch by hand so that I can watch the bots and follow up with expected results/skipping this test as appropriate.

Daniel Bates

Comment 2 2011-04-15 20:06:15 PDT

Created attachment 89907 [details] Layout test Renamed test from pan-scroll-click-hyperlink.html to panScroll-click-hyperlink.html so as to be consistent with the naming convention used for pan scroll tests.

Adam Barth

Comment 3 2011-04-17 01:33:39 PDT

Comment on attachment 89907 [details] Layout test Yay tests.

Daniel Bates

Comment 4 2011-04-26 10:12:33 PDT

Committed r84922: <http://trac.webkit.org/changeset/84922>

Zan Dobersek

Comment 5 2012-07-20 11:30:01 PDT

I've only stumbled upon the panScroll-click-hyperlink.html test just now. Searching through the LayoutTests directories for panScroll* tests, they are all based in platform/win except for this test. Because of that all the other ports are having specific baselines that just say pan scrolling is not supported. The exceptions are chromium-win and win directories in LayoutTests/platform. Would it be OK to move this test into LayoutTests/platform/win and remove other baselines or is it somehow required for this test to be run on all platforms?

Daniel Bates

Comment 6 2012-07-20 12:53:27 PDT

(In reply to comment #5) > [...] > Would it be OK to move this test into LayoutTests/platform/win and remove other baselines or is it somehow required for this test to be run on all platforms? Sounds reasonable to me.

Daniel Bates

Comment 7 2012-07-20 12:55:50 PDT

For completeness, fast/events/panScroll-click-hyperlink.html passes for qt-win.

Zan Dobersek

Comment 8 2012-07-24 06:37:01 PDT

(In reply to comment #7) > For completeness, fast/events/panScroll-click-hyperlink.html passes for qt-win. That makes sense. chromium-win already runs all the tests in platform/win, but I can't tell for sure if that goes for qt-win as well. Anyway, if the test is run, the baseline will be picked from the platform/win location, so both chromium-win and qt-win baselines for this test can be removed.

Note You need to log in before you can comment on or make changes to this bug.