Summary: | Chromium DevTools: Network panel timing test is flaky | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Vsevolod Vlasov <vsevik> | ||||||
Component: | Web Inspector (Deprecated) | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | abarth, commit-queue, eric, ojan, pfeldman, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Vsevolod Vlasov
2011-04-15 15:09:09 PDT
Created attachment 90023 [details]
Patch
Created attachment 90024 [details]
Fixed formatting
Comment on attachment 90024 [details]
Fixed formatting
This could only reduce flakiness, not eliminiate it. Is there a way to do this test not involving timings?
First of all the whole point of this test is to check that timings information coming from network stack (through the net log) is correct, so it would be hard to test that without timings. Essentially, this is our way to test that devtools_netlog_observer working on the real network stack gives us correct data. Secondly, I believe this should eliminate flakiness. I guess the only reason test was failing before was flush() behavior on testserver. The beginning and the end of the response could have come in the same piece of data, thus making resource.endTime - resource.responseReceivedTime close to zero. Comment on attachment 90024 [details] Fixed formatting Clearing flags on attachment: 90024 Committed r84258: <http://trac.webkit.org/changeset/84258> All reviewed patches have been landed. Closing bug. http://trac.webkit.org/changeset/84258 might have broken Windows 7 Release (Tests) |