Summary: | Implement localize strings for windows WebKit2 | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Sam Weinig <sam> | ||||
Component: | New Bugs | Assignee: | Sam Weinig <sam> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth, eric, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Other | ||||||
OS: | OS X 10.5 | ||||||
Attachments: |
|
Description
Sam Weinig
2011-04-15 13:25:34 PDT
Created attachment 89841 [details]
Patch
Attachment 89841 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/platform/win/LocalizedStringsWin.cpp:33: "wtf/RetainPtr.h" already included at Source/WebCore/platform/win/LocalizedStringsWin.cpp:32 [build/include] [4]
Source/WebCore/platform/win/LocalizedStringsWin.cpp:72: Use 0 instead of NULL. [readability/null] [5]
Total errors found: 2 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 89841 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=89841&action=review > Source/WebCore/platform/win/LocalizedStringsWin.cpp:49 > + ASSERT(length && length < WTF_ARRAY_LENGTH(dllPathBuffer)); This should be two separate assertions. > Source/WebCore/platform/win/LocalizedStringsWin.cpp:64 > +static CFBundleRef webKitBundle() > +{ > + static CFBundleRef bundle = createWebKitBundle(); > + ASSERT(bundle); > + return bundle; > +} We should expose this to WebKit1 and WebKit2 so they don't need their own definitions. (In reply to comment #3) > (From update of attachment 89841 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=89841&action=review > > > Source/WebCore/platform/win/LocalizedStringsWin.cpp:49 > > + ASSERT(length && length < WTF_ARRAY_LENGTH(dllPathBuffer)); > > This should be two separate assertions. > > > Source/WebCore/platform/win/LocalizedStringsWin.cpp:64 > > +static CFBundleRef webKitBundle() > > +{ > > + static CFBundleRef bundle = createWebKitBundle(); > > + ASSERT(bundle); > > + return bundle; > > +} > > We should expose this to WebKit1 and WebKit2 so they don't need their own definitions. Indeed, will do that in a follow up so I don't break too much at once. Committed r84033: <http://trac.webkit.org/changeset/84033> http://trac.webkit.org/changeset/84033 might have broken GTK Linux 64-bit Debug and WinCE Release (Build) The following tests are not passing: fast/html/details-add-summary-1-and-click.html fast/html/details-add-summary-1.html fast/html/details-add-summary-10-and-click.html fast/html/details-add-summary-10.html fast/html/details-add-summary-2-and-click.html fast/html/details-add-summary-2.html fast/html/details-add-summary-3-and-click.html fast/html/details-add-summary-3.html fast/html/details-add-summary-4-and-click.html fast/html/details-add-summary-4.html fast/html/details-add-summary-5-and-click.html fast/html/details-add-summary-5.html fast/html/details-add-summary-6-and-click.html fast/html/details-add-summary-6.html fast/html/details-add-summary-7-and-click.html fast/html/details-add-summary-7.html fast/html/details-add-summary-8-and-click.html fast/html/details-add-summary-8.html fast/html/details-add-summary-9-and-click.html fast/html/details-add-summary-9.html fast/html/details-no-summary1.html fast/html/details-no-summary2.html fast/html/details-no-summary3.html fast/html/details-no-summary4.html fast/html/details-open-javascript.html fast/html/details-open1.html fast/html/details-open2.html fast/html/details-open3.html fast/html/details-open4.html fast/html/details-open5.html fast/html/details-open6.html fast/html/details-position.html fast/html/details-remove-summary-1-and-click.html fast/html/details-remove-summary-1.html fast/html/details-remove-summary-2-and-click.html fast/html/details-remove-summary-2.html fast/html/details-remove-summary-3-and-click.html fast/html/details-remove-summary-3.html fast/html/details-remove-summary-4-and-click.html fast/html/details-remove-summary-4.html fast/html/details-remove-summary-5-and-click.html fast/html/details-remove-summary-5.html fast/html/details-remove-summary-6-and-click.html fast/html/details-remove-summary-6.html fast/html/details-writing-mode.html |