Bug 58648

Summary: Expose unified Quota API if QUOTA build flag is enabled
Product: WebKit Reporter: Kinuko Yasuda <kinuko>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dmikurube, ericu, eric, fishd, gustavo.noronha, gustavo, levin, webkit-ews, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 60355    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch levin: review+

Kinuko Yasuda
Reported 2011-04-15 01:56:39 PDT
Per public discussion on public-webapps, we want expose the unified quota API that allows webapps to request/query the current storage usage and quota. http://lists.w3.org/Archives/Public/public-webapps/2011JanMar/0346.html The API is not standardized yet so it needs to be vendor-prefixed.
Attachments
Patch (34.53 KB, patch)
2011-04-15 02:08 PDT, Kinuko Yasuda 		no flags
DetailsFormatted DiffDiff
Patch (44.78 KB, patch)
2011-04-15 04:03 PDT, Kinuko Yasuda 		no flags
DetailsFormatted DiffDiff
Patch (46.87 KB, patch)
2011-04-15 07:26 PDT, Kinuko Yasuda 		no flags
DetailsFormatted DiffDiff
Patch (47.41 KB, patch)
2011-04-15 10:36 PDT, Kinuko Yasuda 		no flags
DetailsFormatted DiffDiff
Patch (47.62 KB, patch)
2011-04-15 12:41 PDT, Kinuko Yasuda 		levin: review+
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Kinuko Yasuda
Comment 1 2011-04-15 02:08:11 PDT
Created attachment 89756 [details] Patch
Kinuko Yasuda
Comment 2 2011-04-15 04:03:18 PDT
Created attachment 89763 [details] Patch
Early Warning System Bot
Comment 3 2011-04-15 06:50:28 PDT
Attachment 89763 [details] did not build on qt: Build output: http://queues.webkit.org/results/8459151
Collabora GTK+ EWS bot
Comment 4 2011-04-15 07:01:46 PDT
Attachment 89763 [details] did not build on gtk: Build output: http://queues.webkit.org/results/8452151
Kinuko Yasuda
Comment 5 2011-04-15 07:26:20 PDT
Created attachment 89784 [details] Patch
Kinuko Yasuda
Comment 6 2011-04-15 10:36:28 PDT
Created attachment 89807 [details] Patch
Kinuko Yasuda
Comment 7 2011-04-15 12:41:26 PDT
Created attachment 89830 [details] Patch Rebased.
David Levin
Comment 8 2011-04-15 14:24:04 PDT
Comment on attachment 89830 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=89830&action=review ok. A few minor nits. > Source/WebCore/page/DOMWindow.cpp:791 > + remove the blank line. > Source/WebCore/storage/StorageInfo.idl:2 > + * Copyright (C) 2008, 2009 Apple Inc. All rights reserved. This copyright line looks incorrect.
David Levin
Comment 9 2011-04-15 14:25:23 PDT
(In reply to comment #0) > Per public discussion on public-webapps, we want expose the unified quota API that allows webapps to request/query the current storage usage and quota. > http://lists.w3.org/Archives/Public/public-webapps/2011JanMar/0346.html > > The API is not standardized yet so it needs to be vendor-prefixed. And prefix it before check in.
Kinuko Yasuda
Comment 10 2011-04-15 14:30:09 PDT
Thanks! (In reply to comment #9) > (In reply to comment #0) > > Per public discussion on public-webapps, we want expose the unified quota API that allows webapps to request/query the current storage usage and quota. > > http://lists.w3.org/Archives/Public/public-webapps/2011JanMar/0346.html > > > > The API is not standardized yet so it needs to be vendor-prefixed. > > And prefix it before check in. The entry interface (StorageInfo) is prefixed by webkit (i.e. webkitStorageInfo) in DOMWindow.idl.
David Levin
Comment 11 2011-04-15 14:52:45 PDT
(In reply to comment #10) > (In reply to comment #9) > > And prefix it before check in. > The entry interface (StorageInfo) is prefixed by webkit (i.e. webkitStorageInfo) in DOMWindow.idl. Ah ok.
Kinuko Yasuda
Comment 12 2011-04-15 16:59:07 PDT
Committed r84053: <http://trac.webkit.org/changeset/84053>
WebKit Review Bot
Comment 13 2011-04-15 18:22:10 PDT
http://trac.webkit.org/changeset/84053 might have broken WinCairo Debug (Build)
Note You need to log in before you can comment on or make changes to this bug.