Summary: | Expose unified Quota API if QUOTA build flag is enabled | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Kinuko Yasuda <kinuko> | ||||||||||||
Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | abarth, dmikurube, ericu, eric, fishd, gustavo.noronha, gustavo, levin, webkit-ews, webkit.review.bot, xan.lopez | ||||||||||||
Priority: | P2 | ||||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||
Hardware: | PC | ||||||||||||||
OS: | OS X 10.5 | ||||||||||||||
Bug Depends on: | |||||||||||||||
Bug Blocks: | 60355 | ||||||||||||||
Attachments: |
|
Description
Kinuko Yasuda
2011-04-15 01:56:39 PDT
Created attachment 89756 [details]
Patch
Created attachment 89763 [details]
Patch
Attachment 89763 [details] did not build on qt: Build output: http://queues.webkit.org/results/8459151 Attachment 89763 [details] did not build on gtk: Build output: http://queues.webkit.org/results/8452151 Created attachment 89784 [details]
Patch
Created attachment 89807 [details]
Patch
Created attachment 89830 [details]
Patch
Rebased.
Comment on attachment 89830 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=89830&action=review ok. A few minor nits. > Source/WebCore/page/DOMWindow.cpp:791 > + remove the blank line. > Source/WebCore/storage/StorageInfo.idl:2 > + * Copyright (C) 2008, 2009 Apple Inc. All rights reserved. This copyright line looks incorrect. (In reply to comment #0) > Per public discussion on public-webapps, we want expose the unified quota API that allows webapps to request/query the current storage usage and quota. > http://lists.w3.org/Archives/Public/public-webapps/2011JanMar/0346.html > > The API is not standardized yet so it needs to be vendor-prefixed. And prefix it before check in. Thanks! (In reply to comment #9) > (In reply to comment #0) > > Per public discussion on public-webapps, we want expose the unified quota API that allows webapps to request/query the current storage usage and quota. > > http://lists.w3.org/Archives/Public/public-webapps/2011JanMar/0346.html > > > > The API is not standardized yet so it needs to be vendor-prefixed. > > And prefix it before check in. The entry interface (StorageInfo) is prefixed by webkit (i.e. webkitStorageInfo) in DOMWindow.idl. (In reply to comment #10) > (In reply to comment #9) > > And prefix it before check in. > The entry interface (StorageInfo) is prefixed by webkit (i.e. webkitStorageInfo) in DOMWindow.idl. Ah ok. Committed r84053: <http://trac.webkit.org/changeset/84053> http://trac.webkit.org/changeset/84053 might have broken WinCairo Debug (Build) |