Bug 58637 – REGRESSION: Rendering in <video> element appears to render quickly to catch up if it has been playing in a background tab

• Component: Media
• Status: RESOLVED FIXED

[Jer Noble]

1. Load <http://flyingmeat.com/stuff/doubledoubleyourstrokestyle.mov> in a tab, then switch to a background tab.
2. Wait around 30 seconds.
3. Switch back to the tab with the video.

The video renders at high speed as it catches back up to the correct playback position.

[Jer Noble]

<rdar://problem/9144405>

[Jer Noble]

Created attachment 89742 [details]
Patch

[Eric Carlson]

Comment on attachment 89742 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=89742&action=review

> Source/WebKit2/WebProcess/WebPage/ca/mac/LayerTreeHostCAMac.mm:119
> +    CALayer* root = rootLayer()->platformLayer();
> +    [[NSNotificationCenter defaultCenter] postNotificationName:@"NSCAViewRenderDidPauseNotification" object:nil userInfo:[NSDictionary dictionaryWithObject:root forKey:@"layer"]];
> +    [root setValue:(id)kCFBooleanTrue forKey:@"NSCAViewRenderPaused"];

Shouldn't you set the property before posting the notification?

> Source/WebKit2/WebProcess/WebPage/ca/mac/LayerTreeHostCAMac.mm:126
> +    CALayer* root = rootLayer()->platformLayer();
> +    [[NSNotificationCenter defaultCenter] postNotificationName:@"NSCAViewRenderDidResumeNotification" object:nil userInfo:[NSDictionary dictionaryWithObject:root forKey:@"layer"]];
> +     [root setValue:(id)kCFBooleanFalse forKey:@"NSCAViewRenderPaused"];

Ditto.

[Jer Noble]

Created attachment 89806 [details]
Patch

[Jer Noble]

Committed r83994: <http://trac.webkit.org/changeset/83994>