IndexedDB delete() should fail if key is null

• Component: New Bugs
• Status: RESOLVED FIXED

[Mark Pilgrim (Google)]

http://dvcs.w3.org/hg/IndexedDB/raw-file/tip/Overview.html#widl-IDBObjectStore-delete states "If the key parameter is not a valid key this method throws a DATA_ERR exception." Then it goes on to say that key can not be null. Mozilla correctly throws in this case, but WebKit does not throw.

[Mark Pilgrim (Google)]

Created attachment 89702 [details]
test case

[Mark Pilgrim (Google)]

Created attachment 91097 [details]
patch with changelog and layouttest

patch to check if key is null in IDBObjectStoreBackendImpl.cpp::deleteFunction

[David Grogan]

Comment on attachment 91097 [details]
patch with changelog and layouttest

View in context: https://bugs.webkit.org/attachment.cgi?id=91097&action=review

Code LG, just nits.

> third_party/WebKit/Source/WebCore/ChangeLog:5
> +        IndexedDB object store delete should fail if key is null

make more obvious that you're referring to an object store deleting an entry, not an entire object store being deleted. e.g. myObjectStore.delete(null)

> third_party/WebKit/LayoutTests/storage/indexeddb/mozilla/key-requirements-delete-null-key.html:45
> +function cleanDatabase()

Change to something not misleading, e.g. cleanDatabaseAndCreateObjectStore or just inSetVersion

[Tony Chang]

Comment on attachment 91097 [details]
patch with changelog and layouttest

Feel free to upload a patch addressing David's nits and I will cq+ it.

[Mark Pilgrim (Google)]

Created attachment 91188 [details]
nits addressed

[David Grogan]

Comment on attachment 91188 [details]
nits addressed

LGTM

[Mark Pilgrim (Google)]

Created attachment 91212 [details]
rebase webkit directory

[Mark Pilgrim (Google)]

Created attachment 91284 [details]
nits addressed once again (regression in previous patch)

[WebKit Commit Bot]

Comment on attachment 91284 [details]
nits addressed once again (regression in previous patch)

Clearing flags on attachment: 91284

Committed r85145: <http://trac.webkit.org/changeset/85145>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.