Bug 58614

Summary:

IndexedDB delete() should fail if key is null

Product:

WebKit

Reporter:

Mark Pilgrim (Google) <pilgrim>

Component:

New Bugs

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, dgrogan, fishd, hans, pilgrim

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
test case	none
patch with changelog and layouttest	tony: review+
nits addressed	none
rebase webkit directory	none
nits addressed once again (regression in previous patch)	none

Mark Pilgrim (Google)

Reported 2011-04-14 17:42:52 PDT

http://dvcs.w3.org/hg/IndexedDB/raw-file/tip/Overview.html#widl-IDBObjectStore-delete states "If the key parameter is not a valid key this method throws a DATA_ERR exception." Then it goes on to say that key can not be null. Mozilla correctly throws in this case, but WebKit does not throw.

Attachments
test case (1.66 KB, text/html) 2011-04-14 17:43 PDT, Mark Pilgrim (Google)	no flags	Details
patch with changelog and layouttest (5.48 KB, patch) 2011-04-26 06:50 PDT, Mark Pilgrim (Google)	tony: review+	Details Formatted Diff Diff
nits addressed (5.54 KB, patch) 2011-04-26 17:04 PDT, Mark Pilgrim (Google)	no flags	Details Formatted Diff Diff
rebase webkit directory (5.20 KB, patch) 2011-04-26 19:35 PDT, Mark Pilgrim (Google)	no flags	Details Formatted Diff Diff
nits addressed once again (regression in previous patch) (5.26 KB, patch) 2011-04-27 08:28 PDT, Mark Pilgrim (Google)	no flags	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Mark Pilgrim (Google)

Comment 1 2011-04-14 17:43:41 PDT

Created attachment 89702 [details] test case

Mark Pilgrim (Google)

Comment 2 2011-04-26 06:50:05 PDT

Created attachment 91097 [details] patch with changelog and layouttest patch to check if key is null in IDBObjectStoreBackendImpl.cpp::deleteFunction

David Grogan

Comment 3 2011-04-26 15:45:49 PDT

Comment on attachment 91097 [details] patch with changelog and layouttest View in context: https://bugs.webkit.org/attachment.cgi?id=91097&action=review Code LG, just nits. > third_party/WebKit/Source/WebCore/ChangeLog:5 > + IndexedDB object store delete should fail if key is null make more obvious that you're referring to an object store deleting an entry, not an entire object store being deleted. e.g. myObjectStore.delete(null) > third_party/WebKit/LayoutTests/storage/indexeddb/mozilla/key-requirements-delete-null-key.html:45 > +function cleanDatabase() Change to something not misleading, e.g. cleanDatabaseAndCreateObjectStore or just inSetVersion

Tony Chang

Comment 4 2011-04-26 16:10:54 PDT

Comment on attachment 91097 [details] patch with changelog and layouttest Feel free to upload a patch addressing David's nits and I will cq+ it.

Mark Pilgrim (Google)

Comment 5 2011-04-26 17:04:33 PDT

Created attachment 91188 [details] nits addressed

David Grogan

Comment 6 2011-04-26 17:15:16 PDT

Comment on attachment 91188 [details] nits addressed LGTM

Mark Pilgrim (Google)

Comment 7 2011-04-26 19:35:20 PDT

Created attachment 91212 [details] rebase webkit directory

Mark Pilgrim (Google)

Comment 8 2011-04-27 08:28:32 PDT

Created attachment 91284 [details] nits addressed once again (regression in previous patch)

WebKit Commit Bot

Comment 9 2011-04-27 21:12:08 PDT

Comment on attachment 91284 [details] nits addressed once again (regression in previous patch) Clearing flags on attachment: 91284 Committed r85145: <http://trac.webkit.org/changeset/85145>

WebKit Commit Bot

Comment 10 2011-04-27 21:12:13 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.