Bug 58579

Summary: Presence of vsnprintf is not depending on compiler, but on windows C runtime used
Product: WebKit Reporter: Fridrich Strba <fridrich.strba>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, buildbot, commit-queue, dglazkov, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows XP   
Attachments:
Description Flags
Patch
none
Modified patch: instead of OS(WINDOWS) test, add just COMPILER(MINGW) to that branch
none
A new version of patch: removing accidental paste of unrelated garbage in the Source/WebCore/dom/XMLDocumentParserLibxml2.cpp none

Fridrich Strba
Reported 2011-04-14 14:53:04 PDT
The vsnprintf is part of Microsoft C runtime. So, don't condition its use on COMPILER(MSVC), but on OS(WINDOWS)
Attachments
Patch (1.51 KB, patch)
2011-04-14 14:57 PDT, Fridrich Strba 		no flags
DetailsFormatted DiffDiff
Modified patch: instead of OS(WINDOWS) test, add just COMPILER(MINGW) to that branch (1.78 KB, patch)
2011-04-15 00:00 PDT, Fridrich Strba 		no flags
DetailsFormatted DiffDiff
A new version of patch: removing accidental paste of unrelated garbage in the Source/WebCore/dom/XMLDocumentParserLibxml2.cpp (1.47 KB, patch)
2011-04-15 00:06 PDT, Fridrich Strba 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Fridrich Strba
Comment 1 2011-04-14 14:57:23 PDT
Created attachment 89661 [details] Patch
Alexey Proskuryakov
Comment 2 2011-04-14 19:05:24 PDT
As you say, the presence of vsnprintf depends on C runtime - so why is OS(WINDOWS) appropriate?
Fridrich Strba
Comment 3 2011-04-14 21:40:21 PDT
(In reply to comment #2) > As you say, the presence of vsnprintf depends on C runtime - so why is OS(WINDOWS) appropriate? Because the only relevant compilers out there and used by Webkit (MSVC and MinGW) link against the Microsoft C runtime
Fridrich Strba
Comment 4 2011-04-15 00:00:48 PDT
Created attachment 89744 [details] Modified patch: instead of OS(WINDOWS) test, add just COMPILER(MINGW) to that branch
Fridrich Strba
Comment 5 2011-04-15 00:03:56 PDT
(In reply to comment #2) > As you say, the presence of vsnprintf depends on C runtime - so why is OS(WINDOWS) appropriate? I modified the patch so that it only adds the COMPILER(MINGW) to the test. On a second thought, one can imagine a Windows compiler that comes with its own C runtime that is different from the Microsoft one.
WebKit Review Bot
Comment 6 2011-04-15 00:05:04 PDT
Attachment 89744 [details] did not build on chromium: Build output: http://queues.webkit.org/results/8452070
Fridrich Strba
Comment 7 2011-04-15 00:06:43 PDT
Created attachment 89745 [details] A new version of patch: removing accidental paste of unrelated garbage in the Source/WebCore/dom/XMLDocumentParserLibxml2.cpp
Build Bot
Comment 8 2011-04-15 00:22:47 PDT
Attachment 89744 [details] did not build on win: Build output: http://queues.webkit.org/results/8452076
Adam Barth
Comment 9 2011-04-17 01:38:03 PDT
Comment on attachment 89745 [details] A new version of patch: removing accidental paste of unrelated garbage in the Source/WebCore/dom/XMLDocumentParserLibxml2.cpp Ok.
Fridrich Strba
Comment 10 2011-05-03 02:24:37 PDT
This one has a positive review. Anybody can put a nice "+" to the commit-queue too?
Xan Lopez
Comment 11 2011-05-04 13:45:47 PDT
Comment on attachment 89745 [details] A new version of patch: removing accidental paste of unrelated garbage in the Source/WebCore/dom/XMLDocumentParserLibxml2.cpp cq+
WebKit Commit Bot
Comment 12 2011-05-04 15:56:03 PDT
Comment on attachment 89745 [details] A new version of patch: removing accidental paste of unrelated garbage in the Source/WebCore/dom/XMLDocumentParserLibxml2.cpp Clearing flags on attachment: 89745 Committed r85800: <http://trac.webkit.org/changeset/85800>
WebKit Commit Bot
Comment 13 2011-05-04 15:56:09 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.