| Summary: | Evaluate PLATFORM(GTK) before OS(WINDOWS) | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Fridrich Strba <fridrich.strba> | ||||
| Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | abarth, commit-queue, eric, webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | PC | ||||||
| OS: | OS X 10.5 | ||||||
| Attachments: |
|
||||||
|
Description
Fridrich Strba
2011-04-14 14:43:20 PDT
Created attachment 89656 [details]
Patch
Comment on attachment 89656 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=89656&action=review > Source/WebCore/platform/FileSystem.h:-80 > -#if OS(WINDOWS) It might be better here to simply change this to #if OS(WINDOWS) && !PLATFORM(GTK) (In reply to comment #2) > (From update of attachment 89656 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=89656&action=review > > > Source/WebCore/platform/FileSystem.h:-80 > > -#if OS(WINDOWS) > > It might be better here to simply change this to #if OS(WINDOWS) && !PLATFORM(GTK) In my opinion, moving the 3 lines is producing more readable code and correspond to what for instance QT port does, the evaluation of its platform comes before the windows evaluation. There is already enough of forest of ifdefs so that the stuff be even more offuscated :) The commit-queue encountered the following flaky tests while processing attachment 89656 [details]: http/tests/xmlhttprequest/logout.html bug 52047 (author: ap@webkit.org) The commit-queue is continuing to process your patch. Comment on attachment 89656 [details] Patch Clearing flags on attachment: 89656 Committed r84059: <http://trac.webkit.org/changeset/84059> All reviewed patches have been landed. Closing bug. http://trac.webkit.org/changeset/84059 might have broken WinCairo Debug (Build) |