| Summary: | Since gcc 4.5.0, windows x64 symbols are not prefixed by underscore | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Fridrich Strba <fridrich.strba> | ||||||
| Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | abarth, aroben, barraclough, commit-queue, eric, mrobinson, oliver, webkit.review.bot, xan.lopez | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | PC | ||||||||
| OS: | Windows XP | ||||||||
| Attachments: |
|
||||||||
|
Description
Fridrich Strba
2011-04-14 14:34:38 PDT
Created attachment 89649 [details]
Patch
Attachment 89649 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1
Source/JavaScriptCore/jit/JITStubs.cpp:84: Missing space after , [whitespace/comma] [3]
Total errors found: 1 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 89669 [details]
Patch
The commit-queue encountered the following flaky tests while processing attachment 89669 [details]: http/tests/misc/favicon-loads-with-icon-loading-override.html bug 58412 (author: alice.liu@apple.com) http/tests/xmlhttprequest/failed-auth.html bug 51835 (author: ap@webkit.org) The commit-queue is continuing to process your patch. Comment on attachment 89669 [details] Patch Clearing flags on attachment: 89669 Committed r84048: <http://trac.webkit.org/changeset/84048> All reviewed patches have been landed. Closing bug. http://trac.webkit.org/changeset/84048 might have broken WinCairo Debug (Build) |