Bug 58562 – queues.webkit.org should display when a bot last rebooted

• Component: New Bugs
• Status: RESOLVED FIXED

[Eric Seidel (no email)]

queues.webkit.org should display when a bot last rebooted

[Eric Seidel (no email)]

Created attachment 89632 [details]
Patch

[Mihai Parparita]

Comment on attachment 89632 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=89632&action=review

> Tools/QueueStatusServer/templates/queuestatus.html:12
> +Last Pass: {{ last_pass.date|timesince }} ago

You may be able to move this to a sub-template that you then use {% with "foo" as param %} {%include "summary_snippet.html" %} {% endwidth %}

However, this is kind of awkward pre-Django 1.3 (where you can specify the parameters directly in the include tag: http://docs.djangoproject.com/en/dev/ref/templates/builtins/?from=olddocs#include), since you need a with statement per parameter.

I'd say the repetition is fine for just two places.

[WebKit Commit Bot]

Comment on attachment 89632 [details]
Patch

Clearing flags on attachment: 89632

Committed r83956: <http://trac.webkit.org/changeset/83956>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.