Bug 58562

Summary: queues.webkit.org should display when a bot last rebooted
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: New BugsAssignee: Eric Seidel (no email) <eric>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue, mihai, ojan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch none

Description Eric Seidel (no email) 2011-04-14 13:01:06 PDT
queues.webkit.org should display when a bot last rebooted
Comment 1 Eric Seidel (no email) 2011-04-14 13:04:19 PDT
Created attachment 89632 [details]
Patch
Comment 2 Mihai Parparita 2011-04-14 13:16:56 PDT
Comment on attachment 89632 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=89632&action=review

> Tools/QueueStatusServer/templates/queuestatus.html:12
> +Last Pass: {{ last_pass.date|timesince }} ago

You may be able to move this to a sub-template that you then use {% with "foo" as param %} {%include "summary_snippet.html" %} {% endwidth %}

However, this is kind of awkward pre-Django 1.3 (where you can specify the parameters directly in the include tag: http://docs.djangoproject.com/en/dev/ref/templates/builtins/?from=olddocs#include), since you need a with statement per parameter.

I'd say the repetition is fine for just two places.
Comment 3 WebKit Commit Bot 2011-04-15 00:54:43 PDT
Comment on attachment 89632 [details]
Patch

Clearing flags on attachment: 89632

Committed r83956: <http://trac.webkit.org/changeset/83956>
Comment 4 WebKit Commit Bot 2011-04-15 00:54:49 PDT
All reviewed patches have been landed.  Closing bug.