Bug 58560

Summary: Port Mozilla's IndexedDB test cases to WebKit
Product: WebKit Reporter: Mark Pilgrim (Google) <pilgrim>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Severity: Normal CC: andreip, dgrogan, fishd, hans, pilgrim
Priority: P3    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Description Flags
first draft of tests (incomplete)
second draft of tests (incomplete)
third draft of tests (incomplete) none

Description Mark Pilgrim (Google) 2011-04-14 11:49:37 PDT
Specifically, these tests: http://mxr.mozilla.org/mozilla2.0/source/dom/indexedDB/test/
Comment 1 Mark Pilgrim (Google) 2011-04-14 11:52:29 PDT
Created attachment 89618 [details]
first draft of tests (incomplete)

For informal review only.
Comment 2 Mark Pilgrim (Google) 2011-04-14 11:54:10 PDT
*** Bug 58356 has been marked as a duplicate of this bug. ***
Comment 3 Mark Pilgrim (Google) 2011-04-14 11:54:33 PDT
*** Bug 58368 has been marked as a duplicate of this bug. ***
Comment 4 Darin Fisher (:fishd, Google) 2011-04-14 13:11:53 PDT
hans, david, andrei:  it'd be great if you could review this!
Comment 5 Mark Pilgrim (Google) 2011-04-14 17:57:38 PDT
Created attachment 89706 [details]
second draft of tests (incomplete)

Changed webkitIndexedDB to unprefixed + our prefix + Moz prefix, as per discussion with dgrogan. Also added several new tests (key-requirements-*)
Comment 6 Mark Pilgrim (Google) 2011-04-15 10:45:40 PDT
Created attachment 89809 [details]
third draft of tests (incomplete)

more tests added for versionchange event, getting put values, aborting setVersion, syntax variations in readonly and read/write transactions, and getting after an aborted transaction
Comment 7 David Grogan 2011-04-15 12:33:22 PDT
The stuff below is copy/pasted because I don't have permission to edit bugs.

Do I have to become a webkit committer before I can edit bugs?

View in context: https://bugs.webkit.org/attachment.cgi?id=89809&action=review

These look good.  Though I only know much about connection-related stuff like open, close, and setVersion.  Hans, do you want to quick-glance for objectstore, index, etc. suboptimalities?

> third_party/WebKit/LayoutTests/storage/indexeddb/mozilla/versionchange.html:45
> +    request.onblocked = unexpectedErrorCallback;

There's an unexpectedBlockCallback or unexpectedBlockedCallback (extra "ed") that you can use.
Comment 8 Mark Pilgrim (Google) 2011-04-27 14:40:05 PDT
Split into several bugs.

*** This bug has been marked as a duplicate of bug 59492 ***