| Summary: | Port Mozilla's IndexedDB test cases to WebKit | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Mark Pilgrim (Google) <pilgrim> | ||||||||
| Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||||||
| Status: | RESOLVED DUPLICATE | ||||||||||
| Severity: | Normal | CC: | andreip, dgrogan, fishd, hans, pilgrim | ||||||||
| Priority: | P3 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | All | ||||||||||
| OS: | All | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Mark Pilgrim (Google)
2011-04-14 11:49:37 PDT
Created attachment 89618 [details]
first draft of tests (incomplete)
For informal review only.
*** Bug 58356 has been marked as a duplicate of this bug. *** *** Bug 58368 has been marked as a duplicate of this bug. *** hans, david, andrei: it'd be great if you could review this! Created attachment 89706 [details]
second draft of tests (incomplete)
Changed webkitIndexedDB to unprefixed + our prefix + Moz prefix, as per discussion with dgrogan. Also added several new tests (key-requirements-*)
Created attachment 89809 [details]
third draft of tests (incomplete)
more tests added for versionchange event, getting put values, aborting setVersion, syntax variations in readonly and read/write transactions, and getting after an aborted transaction
The stuff below is copy/pasted because I don't have permission to edit bugs. Do I have to become a webkit committer before I can edit bugs? View in context: https://bugs.webkit.org/attachment.cgi?id=89809&action=review These look good. Though I only know much about connection-related stuff like open, close, and setVersion. Hans, do you want to quick-glance for objectstore, index, etc. suboptimalities? > third_party/WebKit/LayoutTests/storage/indexeddb/mozilla/versionchange.html:45 > + request.onblocked = unexpectedErrorCallback; There's an unexpectedBlockCallback or unexpectedBlockedCallback (extra "ed") that you can use. |