Bug 58527

Summary: [Qt] Compilation errors in GraphicsContex3DQt.cpp
Product: WebKit Reporter: Jarkko Sakkinen <jarkko.j.sakkinen>
Component: WebKit QtAssignee: Nobody <webkit-unassigned>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: benjamin, jarkko.j.sakkinen
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
fixes none

Jarkko Sakkinen
Reported 2011-04-14 04:25:59 PDT
In the line 694, deprecated QString constructor is used. In the line 662, additional brackets are needed.
Attachments
fixes (1.77 KB, patch)
2011-04-14 04:39 PDT, Jarkko Sakkinen 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jarkko Sakkinen
Comment 1 2011-04-14 04:27:43 PDT
I'm putting fixes that do not belong to #57530 here.
Jarkko Sakkinen
Comment 2 2011-04-14 04:39:44 PDT
Created attachment 89555 [details] fixes
Benjamin Poulain
Comment 3 2011-04-14 04:44:13 PDT
Comment on attachment 89555 [details] fixes View in context: https://bugs.webkit.org/attachment.cgi?id=89555&action=review > Source/WebCore/platform/graphics/qt/GraphicsContext3DQt.cpp:597 > + void* addr = m_glWidget->context()->getProcAddress(QString::fromUtf8(nameWithExt.utf8().data())); Youc an convert directly from String to QString: QString(nameWithExt)
Benjamin Poulain
Comment 4 2011-04-14 05:40:18 PDT
*** This bug has been marked as a duplicate of bug 58478 ***
Note You need to log in before you can comment on or make changes to this bug.