Bug 58525 – svg/W3C-SVG-1.1-SE/svgdom-over-01-f.svg crashes in Debug build

• Component: SVG
• Status: RESOLVED FIXED

[Philippe Normand]

#0  0x00002b82fcf8baa4 in WebCore::RenderSVGResourceFilterPrimitive::styleDidChange (this=0x539fea8, diff=WebCore::StyleDifferenceLayout, oldStyle=0x539fdf0) at ../../Source/WebCore/rendering/svg/RenderSVGResourceFilterPrimitive.cpp:48
48	    ASSERT(filter->isSVGResourceFilter());

Thread 1 (Thread 4789):
#0  0x00002b82fcf8baa4 in WebCore::RenderSVGResourceFilterPrimitive::styleDidChange (this=0x539fea8, diff=WebCore::StyleDifferenceLayout, oldStyle=0x539fdf0) at ../../Source/WebCore/rendering/svg/RenderSVGResourceFilterPrimitive.cpp:48
#1  0x00002b82fcef3d58 in WebCore::RenderObject::setStyle (this=0x539fea8, style=...) at ../../Source/WebCore/rendering/RenderObject.cpp:1759
#2  0x00002b82fcef38d5 in WebCore::RenderObject::setAnimatableStyle (this=0x539fea8, style=...) at ../../Source/WebCore/rendering/RenderObject.cpp:1676
#3  0x00002b82fc94b8c3 in WebCore::Node::setRenderStyle (this=0x539fb40, s=...) at ../../Source/WebCore/dom/Node.cpp:1554
#4  0x00002b82fc9261ed in WebCore::Element::recalcStyle (this=0x539fb40, change=WebCore::Node::Force) at ../../Source/WebCore/dom/Element.cpp:1109
#5  0x00002b82fc926587 in WebCore::Element::recalcStyle (this=0x53928b0, change=WebCore::Node::Force) at ../../Source/WebCore/dom/Element.cpp:1142
#6  0x00002b82fc926587 in WebCore::Element::recalcStyle (this=0x52e73e0, change=WebCore::Node::Force) at ../../Source/WebCore/dom/Element.cpp:1142
#7  0x00002b82fc926587 in WebCore::Element::recalcStyle (this=0x5328320, change=WebCore::Node::Force) at ../../Source/WebCore/dom/Element.cpp:1142
#8  0x00002b82fc8e1cc5 in WebCore::Document::recalcStyle (this=0x50eb9d0, change=WebCore::Node::Force) at ../../Source/WebCore/dom/Document.cpp:1508
#9  0x00002b82fc8e6ab6 in WebCore::Document::styleSelectorChanged (this=0x50eb9d0, updateFlag=WebCore::RecalcStyleImmediately) at ../../Source/WebCore/dom/Document.cpp:2931
#10 0x00002b82fc99b4f4 in WebCore::XMLDocumentParser::end (this=0x5399ca0) at ../../Source/WebCore/dom/XMLDocumentParser.cpp:234
#11 0x00002b82fc99b598 in WebCore::XMLDocumentParser::finish (this=0x5399ca0) at ../../Source/WebCore/dom/XMLDocumentParser.cpp:254
#12 0x00002b82fc8e43f2 in WebCore::Document::finishParsing (this=0x50eb9d0) at ../../Source/WebCore/dom/Document.cpp:2262
#13 0x00002b82fcc1f035 in WebCore::DocumentWriter::endIfNotLoadingMainResource (this=0x2e330f0) at ../../Source/WebCore/loader/DocumentWriter.cpp:224
#14 0x00002b82fcc1ef8b in WebCore::DocumentWriter::end (this=0x2e330f0) at ../../Source/WebCore/loader/DocumentWriter.cpp:209
#15 0x00002b82fcc13113 in WebCore::DocumentLoader::finishedLoading (this=0x2e32ff0) at ../../Source/WebCore/loader/DocumentLoader.cpp:288
#16 0x00002b82fcc2b8cb in WebCore::FrameLoader::finishedLoading (this=0x845ca0) at ../../Source/WebCore/loader/FrameLoader.cpp:2235
#17 0x00002b82fcc5dbfc in WebCore::MainResourceLoader::didFinishLoading (this=0x52b43d0, finishTime=0) at ../../Source/WebCore/loader/MainResourceLoader.cpp:467
#18 0x00002b82fcc69df5 in WebCore::ResourceLoader::didFinishLoading (this=0x52b43d0, finishTime=0) at ../../Source/WebCore/loader/ResourceLoader.cpp:436
#19 0x00002b82fc5a8780 in WebCore::readCallback (source=0x4533aa0, asyncResult=0x2b830c012300, data=0x0) at ../../Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp:779
#20 0x00002b8300790f65 in async_ready_callback_wrapper (source_object=0x4533aa0, res=0x2b830c012300, user_data=0x0) at /tmp/buildd/glib2.0-2.27.91/./gio/ginputstream.c:470
#21 0x00002b83007a2628 in complete_in_idle_cb_for_thread (_data=<value optimized out>) at /tmp/buildd/glib2.0-2.27.91/./gio/gsimpleasyncresult.c:812
#22 0x00002b8301309362 in g_main_dispatch (context=0x7c8730) at /tmp/buildd/glib2.0-2.27.91/./glib/gmain.c:2440
#23 g_main_context_dispatch (context=0x7c8730) at /tmp/buildd/glib2.0-2.27.91/./glib/gmain.c:3013
#24 0x00002b830130da28 in g_main_context_iterate (context=0x7c8730, block=<value optimized out>, dispatch=<value optimized out>, self=<value optimized out>) at /tmp/buildd/glib2.0-2.27.91/./glib/gmain.c:3091
#25 0x00002b830130df35 in g_main_loop_run (loop=0x5398e20) at /tmp/buildd/glib2.0-2.27.91/./glib/gmain.c:3299
#26 0x00002b82ff27c657 in gtk_main () from /usr/lib/libgtk-x11-2.0.so.0
#27 0x0000000000421360 in runTest (testPathOrURL=...) at ../../Tools/DumpRenderTree/gtk/DumpRenderTree.cpp:702
#28 0x00000000004209fd in runTestingServerLoop () at ../../Tools/DumpRenderTree/gtk/DumpRenderTree.cpp:494
#29 0x0000000000422cbf in main (argc=2, argv=0x7fffa2a43428) at ../../Tools/DumpRenderTree/gtk/DumpRenderTree.cpp:1179

[Zoltan Herczeg]

Created attachment 89556 [details]
patch

[Dirk Schulze]

Comment on attachment 89556 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=89556&action=review

> Source/WebCore/ChangeLog:11
> +

Please add a comment, that we have a test that covers this problem.

[Philippe Normand]

Thanks for the quick fix! Would you also mind unskipping the test on GTK?

[Zoltan Herczeg]

Landed in: http://trac.webkit.org/changeset/83839
Unskipped the test in: http://trac.webkit.org/changeset/83840