Bug 58507

Summary:

Add GTest unit-testing framework to WebKit

Product:

WebKit

Reporter:

Dmitry Lomov <dslomov>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dslomov, levin, mrowe, timothy

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Bug Depends on:

Bug Blocks:

21010, 58509

Attachments:

Description	Flags
Adding gtest to Source/ThirdParty + sample test case	none
Adding GTest framework to Source/ThirdParty	dslomov: review-, dslomov: commit-queue-
Adding GTest to Source/ThirdParty	levin: review+, levin: commit-queue-

Dmitry Lomov

Reported 2011-04-13 19:31:09 PDT

Add GTest to Source/ThirdParty, create examples of its use.

Attachments
Adding gtest to Source/ThirdParty + sample test case (deleted) 2011-04-13 20:03 PDT, Dmitry Lomov	no flags	Details Formatted Diff Diff
Adding GTest framework to Source/ThirdParty (deleted) 2011-04-13 20:28 PDT, Dmitry Lomov	dslomov: review- dslomov: commit-queue-	Details Formatted Diff Diff
Adding GTest to Source/ThirdParty (deleted) 2011-04-13 20:36 PDT, Dmitry Lomov	levin: review+ levin: commit-queue-	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Dmitry Lomov

Comment 1 2011-04-13 20:03:07 PDT

Created attachment 89519 [details] Adding gtest to Source/ThirdParty + sample test case

Dmitry Lomov

Comment 2 2011-04-13 20:05:50 PDT

Comment on attachment 89519 [details] Adding gtest to Source/ThirdParty + sample test case Breaking up into two separate patches.

Dmitry Lomov

Comment 3 2011-04-13 20:28:30 PDT

Created attachment 89521 [details] Adding GTest framework to Source/ThirdParty

Dmitry Lomov

Comment 4 2011-04-13 20:36:58 PDT

Created attachment 89522 [details] Adding GTest to Source/ThirdParty

David Levin

Comment 5 2011-04-13 22:16:16 PDT

Comment on attachment 89522 [details] Adding GTest to Source/ThirdParty Based on the status of ews, I suspect this patch is too big for the commit queue.

David Levin

Comment 6 2011-04-14 13:13:30 PDT

Committed as http://trac.webkit.org/changeset/83815

Timothy Hatcher

Comment 7 2011-04-15 11:55:29 PDT

The GTest targets have errors on systems that don't have $(DEVELOPER_SDK_DIR)/MacOSX10.4u.sdk. It should not have an SDK and use the current system.

Mark Rowe (bdash)

Comment 8 2011-04-15 17:57:15 PDT

Can someone expand on how we arrived at using gtest? There appears to have been zero discussion of this and the rather large and complicated library was simply checked in to the source tree.

Note You need to log in before you can comment on or make changes to this bug.