Bug 58497 – Implement drawingBufferWidth/drawingBufferHeight in WebGL

• Component: WebGL
• Status: RESOLVED FIXED

[Zhenyao Mo]

See WebGL spec 1.0 section 2.2.

[Zhenyao Mo]

Created attachment 98036 [details]
Patch

[Zhenyao Mo]

Created attachment 98072 [details]
Patch

[Zhenyao Mo]

Note that this patch doesn't deal with compositing.  I created two new bugs to track the compositing issues for chromium (63101) and safari (63102).  I am working on the chromium port one.

[Kenneth Russell]

Comment on attachment 98072 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=98072&action=review

Looks good overall. One comment, and please make sure any relevant tests are synchronized with the WebGL conformance suite.

> Source/WebCore/html/canvas/WebGLRenderingContext.cpp:608
> +    if (width > maxWidth)
> +        width = maxWidth;
> +    if (width <= 0)
> +        width = 1;

How about a "clamp" helper function? (Too bad the STL doesn't contain one...)

[WebKit Review Bot]

Comment on attachment 98072 [details]
Patch

Attachment 98072 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/8919144

New failing tests:
fast/canvas/webgl/drawingbuffer-test.html

[WebKit Review Bot]

Created attachment 98075 [details]
Archive of layout-test-results from ec2-cr-linux-03

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-03  Port: Chromium  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick

[Zhenyao Mo]

(In reply to comment #4)
> (From update of attachment 98072 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=98072&action=review
> 
> Looks good overall. One comment, and please make sure any relevant tests are synchronized with the WebGL conformance suite.

Yes tests are synced with khronos.

> 
> > Source/WebCore/html/canvas/WebGLRenderingContext.cpp:608
> > +    if (width > maxWidth)
> > +        width = maxWidth;
> > +    if (width <= 0)
> > +        width = 1;
> 
> How about a "clamp" helper function? (Too bad the STL doesn't contain one...)

Will do in the landing patch.

[Zhenyao Mo]

Committed r89393: <http://trac.webkit.org/changeset/89393>