Bug 58479

Summary: Change WebGraphicsContext3D virtuals to pure virtuals as intended
Product: WebKit Reporter: John Bates <jbates>
Component: WebGLAssignee: John Bates <jbates>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, jbates, kbr
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

John Bates
Reported 2011-04-13 14:29:07 PDT
Roll chromium rev and change WebGraphicsContext3D virtuals to pure virtuals as intended
Attachments
Patch (2.28 KB, patch)
2011-04-13 14:29 PDT, John Bates 		no flags
DetailsFormatted DiffDiff
Patch (2.28 KB, patch)
2011-04-14 10:35 PDT, John Bates 		no flags
DetailsFormatted DiffDiff
Patch (1.86 KB, patch)
2011-04-15 18:17 PDT, John Bates 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
John Bates
Comment 1 2011-04-13 14:29:39 PDT
Created attachment 89459 [details] Patch
Kenneth Russell
Comment 2 2011-04-13 15:33:12 PDT
Comment on attachment 89459 [details] Patch Looks good esp since it passed the cr-linux EWS bot. Would have cq+'d this earlier but didn't realize the Chromium Mac EWS bot can't process patches from non-committers.
WebKit Commit Bot
Comment 3 2011-04-14 02:40:39 PDT
Comment on attachment 89459 [details] Patch Rejecting attachment 89459 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=eseidel-cq-sf', 'ap..." exit_code: 2 Last 500 characters of output: neth Russell', u'--force']" exit_code: 1 Parsed 3 diffs from patch file(s). patching file Source/WebKit/chromium/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebKit/chromium/DEPS Hunk #1 FAILED at 32. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebKit/chromium/DEPS.rej patching file Source/WebKit/chromium/public/WebGraphicsContext3D.h Failed to run "[u'/Projects/CommitQueue/Tools/Scripts/svn-apply', u'--reviewer', u'Kenneth Russell', u'--force']" exit_code: 1 Full output: http://queues.webkit.org/results/8403545
John Bates
Comment 4 2011-04-14 10:35:01 PDT
Created attachment 89603 [details] Patch
Kenneth Russell
Comment 5 2011-04-14 10:53:46 PDT
Comment on attachment 89603 [details] Patch Looks fine.
WebKit Commit Bot
Comment 6 2011-04-14 20:54:51 PDT
Comment on attachment 89603 [details] Patch Rejecting attachment 89603 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-8', 'apply-..." exit_code: 2 Last 500 characters of output: nneth Russell', u'--..." exit_code: 1 Parsed 3 diffs from patch file(s). patching file Source/WebKit/chromium/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebKit/chromium/DEPS Hunk #1 FAILED at 32. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebKit/chromium/DEPS.rej patching file Source/WebKit/chromium/public/WebGraphicsContext3D.h Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Kenneth Russell', u'--..." exit_code: 1 Full output: http://queues.webkit.org/results/8450026
John Bates
Comment 7 2011-04-15 18:17:47 PDT
Created attachment 89897 [details] Patch
John Bates
Comment 8 2011-04-15 18:19:19 PDT
OK, let's just leave the DEPS as is this time. The chromium version has been rolled enough by others.
Kenneth Russell
Comment 9 2011-04-15 18:20:28 PDT
Comment on attachment 89897 [details] Patch OK.
WebKit Commit Bot
Comment 10 2011-04-15 21:40:38 PDT
Comment on attachment 89897 [details] Patch Clearing flags on attachment: 89897 Committed r84079: <http://trac.webkit.org/changeset/84079>
WebKit Commit Bot
Comment 11 2011-04-15 21:40:42 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.