Bug 58473 – REGRESSION: Links are clickable when a contentEditable is set to true

• Component: WebKit2
• Status: RESOLVED FIXED

[Enrica Casucci]

Repro steps:
1. Launch Safari and navigate to http://www.mozilla.org/editor/midasdemo/
2. Paste in the editor some content previously copied that contains links.
3. Click on one of the links

Expected
No navigation takes place.

Actual
The page pointed by the link gets loaded in the editor frame.

[Enrica Casucci]

<rdar://problem/9256793>

[Enrica Casucci]

Created attachment 89444 [details]
Patch

Comment on attachment 89444 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=89444&action=review

> Source/WebKit2/UIProcess/API/C/WKPreferencesPrivate.h:53
> +enum WKEditableLinkBehavior {
> +    WKEditableLinkDefaultBehavior,
> +    WKEditableLinkAlwaysLive,
> +    WKEditableLinkOnlyLiveWithShiftKey,
> +    WKEditableLinkLiveWhenNotFocused,
> +    WKEditableLinkNeverLive
> +};
> +typedef enum WKEditableLinkBehavior WKEditableLinkBehavior;

CF-style constants should be prefixed with a lowercase k. These are also missing the word “Behavior”.

[Enrica Casucci]

Created attachment 89447 [details]
Patch2

Addresses Dan's comments.

[Enrica Casucci]

http://trac.webkit.org/changeset/83766

[Enrica Casucci]

Created attachment 89469 [details]
Follow-up patch

[WebKit Review Bot]

Attachment 89469 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1

Source/WebKit2/UIProcess/API/C/WKAPICast.h:190:  A case label should not be indented, but line up with its switch statement.  [whitespace/indent] [4]
Source/WebKit2/UIProcess/API/C/WKPreferences.cpp:34:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 2 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Enrica Casucci]

Created attachment 89476 [details]
Patch4

Comment on attachment 89476 [details]
Patch4

View in context: https://bugs.webkit.org/attachment.cgi?id=89476&action=review

> Source/WebKit2/UIProcess/API/C/WKAPICast.h:46
> +#include <WebCore/Settings.h>

Strange that this is needed here.

> Source/WebKit2/UIProcess/API/C/WKPreferences.cpp:34
> +#include <WebCore/Settings.h>

Ditto.

[WebKit Review Bot]

Attachment 89476 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1

Source/WebKit2/UIProcess/API/C/WKAPICast.h:190:  A case label should not be indented, but line up with its switch statement.  [whitespace/indent] [4]
Source/WebKit2/UIProcess/API/C/WKAPICast.h:209:  A case label should not be indented, but line up with its switch statement.  [whitespace/indent] [4]
Source/WebKit2/UIProcess/API/C/WKPreferences.cpp:34:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 3 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Enrica Casucci]

http://trac.webkit.org/changeset/83778.
Addressed style issues before landing.