Bug 58466

Summary: IndexedDB createIndex should fail if name arg is empty string
Product: WebKit Reporter: Mark Pilgrim (Google) <pilgrim>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED INVALID    
Severity: Normal CC: dgrogan, fishd, hans, pilgrim
Priority: P3    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
test case
none
patch + layouttest none

Mark Pilgrim (Google)
Reported 2011-04-13 11:53:32 PDT
Similiar to bug 58365, but I'm creating a separate bug report because I'm not entirely sure that this behavior is a bug. (On the other hand, I'm sure bug 58365 is a bug.) But I can't find exact spec text to support this bug. Mozilla throws in this case, WebKit does not, so someone is wrong. Opening a bug in case it's us.
Attachments
test case (1.74 KB, text/html)
2011-04-13 11:54 PDT, Mark Pilgrim (Google) 		no flags
Details
patch + layouttest (4.29 KB, patch)
2011-04-25 14:08 PDT, Mark Pilgrim (Google) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mark Pilgrim (Google)
Comment 1 2011-04-13 11:54:23 PDT
Created attachment 89421 [details] test case
Mark Pilgrim (Google)
Comment 2 2011-04-25 14:08:28 PDT
Created attachment 90942 [details] patch + layouttest Spec says several things can be an empty string, but an index name is not one of them. This is a review-ready patch that throws when trying to call createIndex with a name parameter that is an empty string. Plus a layouttest.
David Grogan
Comment 3 2011-04-25 14:41:54 PDT
(In reply to comment #2) > Created an attachment (id=90942) [details] > patch + layouttest > > Spec says several things can be an empty string, but an index name is not one of them. Hrm, it also doesn't forbid it (that I found). I might ask mozilla why they made it throw. > This is a review-ready patch that throws when trying to call createIndex with a name parameter that is an empty string. Plus a layouttest.
Mark Pilgrim (Google)
Comment 4 2011-04-26 10:41:38 PDT
Discussion with SickingJ leads to the conclusion that the spec will be changed to explicitly ALLOW name to be an empty string. Closing this bug. http://lists.w3.org/Archives/Public/public-webapps/2011AprJun/0349.html
Note You need to log in before you can comment on or make changes to this bug.