Summary: | Exclude webkitGetUserMedia from the navigator-detached-no-crash test | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Leandro Graciá Gil <leandrogracia> | ||||||||
Component: | Tools / Tests | Assignee: | Leandro Graciá Gil <leandrogracia> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | jianli, steveblock | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | All | ||||||||||
OS: | All | ||||||||||
Bug Depends on: | 56586 | ||||||||||
Bug Blocks: | 56459 | ||||||||||
Attachments: |
|
Description
Leandro Graciá Gil
2011-04-13 11:09:20 PDT
Created attachment 89408 [details]
Patch
Comment on attachment 89408 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=89408&action=review > LayoutTests/fast/dom/navigator-detached-no-crash.html:56 > + if (p != 'webkitGetUserMedia') { // Don't include the Media Stream API functions until most platforms have support. Can you combine this logic with the existing check for "geolocation" into some common check? Maybe you can keep an excluding list and check this list in for loop. Created attachment 89412 [details]
Patch
Comment on attachment 89408 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=89408&action=review >> LayoutTests/fast/dom/navigator-detached-no-crash.html:56 >> + if (p != 'webkitGetUserMedia') { // Don't include the Media Stream API functions until most platforms have support. > > Can you combine this logic with the existing check for "geolocation" into some common check? Maybe you can keep an excluding list and check this list in for loop. Fixed. Comment on attachment 89412 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=89412&action=review > LayoutTests/fast/dom/navigator-detached-no-crash.html:55 > + if (p != 'geolocation' && p != 'webkitGetUserMedia') { // Don't include Geolocation or the Media Stream API functions until most platforms have support. Better to use early return, like: if (p == 'geolocation' || p == 'webkitGetUserMedia') //... continue; ... Created attachment 89417 [details]
Patch
Comment on attachment 89412 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=89412&action=review >> LayoutTests/fast/dom/navigator-detached-no-crash.html:55 >> + if (p != 'geolocation' && p != 'webkitGetUserMedia') { // Don't include Geolocation or the Media Stream API functions until most platforms have support. > > Better to use early return, like: > if (p == 'geolocation' || p == 'webkitGetUserMedia') //... > continue; > ... Fixed. Committed as https://trac.webkit.org/changeset/83754. |