Bug 58405

Summary: BACKTRACE() macro should check for Debug configuration in macro, not WTFReportBacktrace definition
Product: WebKit Reporter: Paul Knight <pknight>
Component: Web Template FrameworkAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, commit-queue, ddkilzer, joepeck, pknight
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Proposed patch none

Description Paul Knight 2011-04-12 17:53:31 PDT 
The BACKTRACE() macro currently checks whether NDEBUG is defined in the implementation of WTFReportBacktrace, and not in the BACKTRACE() macro. This means you need a Debug JavaScriptCore in order for it to do anything.

It seems the check should be moved to the header file, so you can use BACKTRACE() in a WebCore debug build and not need a Debug JavaScriptCore, similar to the way the other macros like ASSERT() work.
Comment 1 Paul Knight 2011-04-12 21:53:10 PDT 
Created attachment 89337 [details]
Proposed patch
Comment 2 Gavin Barraclough 2011-04-12 22:10:24 PDT 
Comment on attachment 89337 [details]
Proposed patch

Looks great.
Comment 3 WebKit Commit Bot 2011-04-13 01:14:56 PDT 
Comment on attachment 89337 [details]
Proposed patch

Clearing flags on attachment: 89337

Committed r83709: <http://trac.webkit.org/changeset/83709>
Comment 4 WebKit Commit Bot 2011-04-13 01:15:01 PDT 
All reviewed patches have been landed.  Closing bug.